coprocessor: fix panic when _tidb_commit_ts column is placed before PK handle columns#19300
Conversation
e996158 to
7d61378
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a panic that occurs when the _tidb_commit_ts column is placed before PK handle columns in table scans. The fix ensures that commit_ts columns are treated with the same special handling as physical_table_id columns.
Changes:
- Updated column vector construction logic to handle
commit_tscolumns with decoded format when placed before PK handles - Added a new integration test to specifically verify the fix for commit_ts columns before PK handles
- Moved an existing test to the end of the file
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| components/tidb_query_executors/src/table_scan_executor.rs | Fixed panic by adding commit_ts column check alongside physical_table_id column check in two locations where column types are determined |
| tests/integrations/coprocessor/test_select.rs | Added new test for commit_ts column before PK handle scenario and moved existing test_batch_row_limit to end of file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
492e4cb to
7a6eb68
Compare
…K handle columns Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
|
@tiancaiamao: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, ekexium, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…K handle columns (tikv#19300) close tikv#19299 fix panic when _tidb_commit_ts column is placed before PK handle columns Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
…K handle columns (tikv#19300) close tikv#19299 fix panic when _tidb_commit_ts column is placed before PK handle columns Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
…K handle columns (tikv#19300) close tikv#19299 fix panic when _tidb_commit_ts column is placed before PK handle columns Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
What is changed and how it works?
Issue Number: Close #19299
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note