crossbeam-skiplist: fix RefRange iterator memory leak (#19284)#19292
Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-8.5from Jan 22, 2026
Merged
Conversation
RefRange::next() and next_back() were using clone_from() to update self.head/self.tail. Since RefEntry has no Drop implementation, the old entry was dropped without decrementing its refcount, causing permanent memory leaks. Fix by using mem::replace() and manually calling decrement() on the old entry, matching the pattern used in RefIter::next(). Signed-off-by: ekexium <eke@fastmail.com>
9 tasks
Signed-off-by: ekexium <eke@fastmail.com>
overvenus
approved these changes
Jan 22, 2026
cfzjywxk
approved these changes
Jan 22, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
lcwangchao
pushed a commit
to lcwangchao/tikv
that referenced
this pull request
Jan 23, 2026
…ikv#19292) close tikv#19285 Fix RefRange::next() and next_back() to properly decrement old self.head/self.tail refcount. Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: ekexium <eke@fastmail.com> Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
lcwangchao
pushed a commit
to lcwangchao/tikv
that referenced
this pull request
Jan 23, 2026
…ikv#19292) close tikv#19285 Fix RefRange::next() and next_back() to properly decrement old self.head/self.tail refcount. Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: ekexium <eke@fastmail.com> Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #19284
What is changed and how it works?
Issue Number: Close #19285
What's Changed:
Fix a memory leak in
crossbeam-skiplist'sRefRangeiterator.RefRange::next()andnext_back()were usingclone_from()to updateself.head/self.tail. SinceRefEntryhas noDropimplementation (by design - callers must explicitly callrelease()), the old entry was dropped without decrementing its refcount, causing permanent memory leaks.Note that the the comment of
RefEntrysaysThis bug affects any code using
SkipMap::range()iterators. In TiKV, this manifests as memory leaks inLockTablewhencheck_range()orfind_first()are called.The fix matches the pattern already used in
RefIter::next().Stress test results (10 seconds, range iteration + insert/remove cycle):
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note