Skip to content

*: upgrade cargo-deny version to make it compatible to further developments.#19248

Merged
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5from
LykxSassinator:fix_cargo_deny_errs
Jan 4, 2026
Merged

*: upgrade cargo-deny version to make it compatible to further developments.#19248
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5from
LykxSassinator:fix_cargo_deny_errs

Conversation

@LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Dec 30, 2025

What is changed and how it works?

Issue Number: ref #19249

What's Changed:

This PR is a manual cherry-pick of #19233, used to make the cargo-deny compatible to further developments temporarily.

In this PR, some stale packages are marked with error by the upgraded cargo-deny. And since these packages are not remarked with security vulnerabilities, we have chosen to ignore these errors for now.

Upgrades the `cargo-deny` version and ignore some errors.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None.

…pments.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 30, 2025
@LykxSassinator LykxSassinator requested review from hbisheng and overvenus and removed request for hbisheng December 30, 2025 02:56
@LykxSassinator
Copy link
Contributor Author

/cc @wuhuizuo PTAL

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2025

@LykxSassinator: GitHub didn't allow me to request PR reviews from the following users: wuhuizuo, PTAL.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @wuhuizuo PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment on lines -101 to -102
unlicensed = "deny"
copyleft = "deny"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are they covered in version = 2?

Copy link
Contributor Author

@LykxSassinator LykxSassinator Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, these configurations are deprecated after EmbarkStudios/cargo-deny#611.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2025

@wuhuizuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 31, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 31, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: overvenus, wuhuizuo, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 31, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-31 07:44:25.167816093 +0000 UTC m=+169820.986124535: ☑️ agreed by YuJuncen.
  • 2025-12-31 08:02:05.025992979 +0000 UTC m=+170880.844301411: ☑️ agreed by overvenus.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 4, 2026
@ti-chi-bot ti-chi-bot bot merged commit c47d33d into tikv:release-8.5 Jan 4, 2026
5 checks passed
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Jan 13, 2026
ekexium pushed a commit to ti-chi-bot/tikv that referenced this pull request Jan 19, 2026
…pments. (tikv#19248)

ref tikv#19249

Upgrades the `cargo-deny` version and ignore some errors.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants