Skip to content

coprocessor: fix missing analyze scan statistics#19207

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
glorv:fix-analyze
Dec 15, 2025
Merged

coprocessor: fix missing analyze scan statistics#19207
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
glorv:fix-analyze

Conversation

@glorv
Copy link
Contributor

@glorv glorv commented Dec 15, 2025

What is changed and how it works?

Issue Number: Close #19206

What's Changed:

fix missing analyze scan statistics
image

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix the bug that analyze scan kv operation metric is always 0

@glorv
fix analyze scan statistics
ba7522b 
Signed-off-by: glorv <glorvs@163.com>
@glorv glorv added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Dec 15, 2025
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. labels Dec 15, 2025
@glorv glorv requested review from 0xPoe, hbisheng and hhwyt December 15, 2025 08:56
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 15, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 15, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-15 08:58:24.078611045 +0000 UTC m=+1463448.892388607: ☑️ agreed by hhwyt.
  • 2025-12-15 08:59:36.534041368 +0000 UTC m=+1463521.347818940: ☑️ agreed by hbisheng.

0xPoe
0xPoe approved these changes Dec 15, 2025
View reviewed changes
Copy link
Member

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2025

@0xPoe: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Thanks! :shipit:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@glorv
Copy link
Contributor Author

glorv commented Dec 15, 2025

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xPoe, glorv, hbisheng, hhwyt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 15, 2025
@ti-chi-bot ti-chi-bot bot merged commit ccbbda5 into tikv:master Dec 15, 2025
9 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Dec 15, 2025
@glorv glorv deleted the fix-analyze branch December 15, 2025 09:37
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2025

In response to a cherrypick label: new pull request created to branch release-8.1: #19209.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2025
Open
9 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #19210.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 15, 2025
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 15, 2025
@ti-chi-bot @glorv
coprocessor: fix missing analyze scan statistics (#19207) (#19210)
010439c 
close #19206

fix missing analyze scan statistics

Signed-off-by: glorv <glorvs@163.com>

Co-authored-by: glorv <glorvs@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@hbisheng hbisheng hbisheng approved these changes

@0xPoe 0xPoe 0xPoe approved these changes

@hhwyt hhwyt hhwyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

the kv cursor operations metrics is always 0 for analyze request

5 participants

@glorv @ti-chi-bot @hbisheng @0xPoe @hhwyt