Skip to content

txn: add test for rollback & scan shared lock#19200

Merged
cfzjywxk merged 3 commits intotikv:tikv-8.5-with-shared-lockfrom
you06:shared-lock/add-tests
Dec 19, 2025
Merged

txn: add test for rollback & scan shared lock#19200
cfzjywxk merged 3 commits intotikv:tikv-8.5-with-shared-lockfrom
you06:shared-lock/add-tests

Conversation

@you06
Copy link
Contributor

@you06 you06 commented Dec 12, 2025

What is changed and how it works?

Issue Number: ref #19087

What's Changed:

Add rollback and scan lock test for shared lock.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2025
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 16, 2025
@you06 you06 changed the title txn: add test for rollback shared lock txn: add test for rollback & scan shared lock Dec 16, 2025
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 16, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 16, 2025
@you06 you06 mentioned this pull request Dec 19, 2025
13 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 19, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-16 09:22:27.029014856 +0000 UTC m=+1551291.842792428: ☑️ agreed by zyguan.
  • 2025-12-19 06:39:48.94342456 +0000 UTC m=+1800733.757202142: ☑️ agreed by cfzjywxk.

@cfzjywxk cfzjywxk merged commit e7e19d5 into tikv:tikv-8.5-with-shared-lock Dec 19, 2025
2 of 3 checks passed
you06-pingcap pushed a commit to you06/tikv that referenced this pull request Jan 21, 2026
* add test & debug log

Signed-off-by: you06 <you1474600@gmail.com>

* add scan locks test

Signed-off-by: you06 <you1474600@gmail.com>

* add test that shared lock prewrite cannot amend pessimistic lock

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants