Skip to content

br: support SdkError::ServiceError as retryable errors#19197

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
vldmit:fix-s3-error
Dec 16, 2025
Merged

br: support SdkError::ServiceError as retryable errors#19197
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
vldmit:fix-s3-error

Conversation

@vldmit
Copy link
Contributor

@vldmit vldmit commented Dec 11, 2025 •
edited
Loading

What is changed and how it works?

Add SdkError::ServiceError to the is_retryable, allowing to retry S3 puts when AWS returns HTTP 503 Slow Down errors.

Issue Number: Close #19196

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Treat SdkError::ServiceError as retryable, to handle AWS S3 Slow Down response

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2025

Hi @vldmit. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Dec 11, 2025
YuJuncen
YuJuncen approved these changes Dec 11, 2025
View reviewed changes
Copy link
Contributor

@YuJuncen YuJuncen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Would you also fill release notes in PR body?

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 11, 2025
3pointer
3pointer approved these changes Dec 11, 2025
View reviewed changes
Copy link
Contributor

@3pointer 3pointer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

you can run make format and submit again

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-11 06:04:03.462578755 +0000 UTC m=+1107388.276356327: ☑️ agreed by YuJuncen.
  • 2025-12-11 06:08:35.939340354 +0000 UTC m=+1107660.753117926: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Indicates the PR's author has not signed dco. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: yes Indicates the PR's author has signed the dco. labels Dec 16, 2025
@vldmit
br: support SdkError::ServiceError as retryable errors
c9100c3 
Signed-off-by: Vlad Dmitriev <vldmit@gmail.com>
@vldmit
cargo fmt
597b854 
Signed-off-by: Vlad Dmitriev <vldmit@gmail.com>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Dec 16, 2025
@3pointer
Copy link
Contributor

3pointer commented Dec 16, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Dec 16, 2025
@ti-chi-bot ti-chi-bot bot merged commit dac8fb5 into tikv:master Dec 16, 2025
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Dec 16, 2025
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 30, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 30, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #19251.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 30, 2025
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 7, 2026
@ti-chi-bot @vldmit
br: support SdkError::ServiceError as retryable errors (#19197) (#19251)
4d64525 
close #19196

Signed-off-by: Vlad Dmitriev <vldmit@gmail.com>

Co-authored-by: Vlad Dmitriev <vldmit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@3pointer 3pointer 3pointer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

Snapshot backup failures due to S3 rate limiting handling error

4 participants

@vldmit @3pointer @ti-chi-bot @YuJuncen