Skip to content

*: support to return commit timestamp for Get / BatchGet requests#19103

Merged
ti-chi-bot[bot] merged 2 commits intotikv:feature/active-activefrom
lcwangchao:require_commit_ts
Nov 12, 2025
Merged

*: support to return commit timestamp for Get / BatchGet requests#19103
ti-chi-bot[bot] merged 2 commits intotikv:feature/active-activefrom
lcwangchao:require_commit_ts

Conversation

@lcwangchao
Copy link
Contributor

@lcwangchao lcwangchao commented Nov 11, 2025

What is changed and how it works?

Issue Number: Close #19102

What's Changed:

The Get / BatchGet will return the commit_ts for each value if `need_commit_ts` is specified.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 11, 2025

Hi @lcwangchao. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 11, 2025
@lcwangchao lcwangchao changed the title storage: support need_commit_ts for Get / BatchGet requests *: support need_commit_ts for Get / BatchGet requests Nov 11, 2025
@lcwangchao lcwangchao mentioned this pull request Nov 11, 2025
Open
95 tasks
@lcwangchao lcwangchao force-pushed the require_commit_ts branch 2 times, most recently from 40896dd to 98252c3 Compare November 11, 2025 08:42
@lcwangchao lcwangchao changed the title *: support need_commit_ts for Get / BatchGet requests *: support to return commit timestamp for Get / BatchGet requests Nov 11, 2025
@cfzjywxk
Copy link
Collaborator

cfzjywxk commented Nov 11, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 11, 2025
@lcwangchao
Support need_commit_ts for Get / BatchGet requests
3248fe1 
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
@lcwangchao
Copy link
Contributor Author

lcwangchao commented Nov 11, 2025

/retest

zyguan
zyguan reviewed Nov 12, 2025
View reviewed changes
Copy link
Contributor

@zyguan zyguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

cfzjywxk
cfzjywxk reviewed Nov 12, 2025
View reviewed changes
you06
you06 reviewed Nov 12, 2025
View reviewed changes
@lcwangchao
address some comments
886c3a2 
Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 12, 2025
cfzjywxk
cfzjywxk approved these changes Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 12, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-12 04:19:37.38393393 +0000 UTC m=+848626.826963809: ☑️ agreed by zyguan.
  • 2025-11-12 04:47:03.624200978 +0000 UTC m=+850273.067230857: ☑️ agreed by cfzjywxk.

@ti-chi-bot ti-chi-bot bot merged commit b98b60f into tikv:feature/active-active Nov 12, 2025
7 checks passed
@lcwangchao lcwangchao deleted the require_commit_ts branch November 12, 2025 04:59
lcwangchao added a commit to lcwangchao/tikv that referenced this pull request Dec 25, 2025
@lcwangchao
*: support to return commit timestamp for Get / BatchGet requests (ti…
27c5f8a 
…kv#19103)

close tikv#19102

The Get / BatchGet will return the commit_ts for each value if `need_commit_ts` is specified.

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
@lcwangchao lcwangchao mentioned this pull request Dec 25, 2025
Merged
9 tasks
lcwangchao added a commit to lcwangchao/tikv that referenced this pull request Dec 25, 2025
@lcwangchao
*: support to return commit timestamp for Get / BatchGet requests (ti…
60fbda0 
…kv#19103)

close tikv#19102

The Get / BatchGet will return the commit_ts for each value if `need_commit_ts` is specified.

Signed-off-by: Chao Wang <cclcwangchao@hotmail.com>
@lcwangchao lcwangchao mentioned this pull request Jan 21, 2026
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@you06 you06 you06 left review comments

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

@Connor1996 Connor1996 Awaiting requested review from Connor1996

@ekexium ekexium Awaiting requested review from ekexium

+1 more reviewer

@zyguan zyguan zyguan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lcwangchao @cfzjywxk @zyguan @you06