Skip to content

txn: implement Lock encode/decode#19091

Merged
cfzjywxk merged 4 commits intotikv:tikv-8.5-with-shared-lockfrom
you06:8.5-shared-lock/lock
Nov 7, 2025
Merged

txn: implement Lock encode/decode#19091
cfzjywxk merged 4 commits intotikv:tikv-8.5-with-shared-lockfrom
you06:8.5-shared-lock/lock

Conversation

@you06
Copy link
Contributor

@you06 you06 commented Nov 5, 2025

What is changed and how it works?

Issue Number: ref #19087

What's Changed:

Implemente encode/decode for shared lock.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

you06 added 2 commits November 5, 2025 17:53
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 5, 2025
you06 added 2 commits November 6, 2025 12:02
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
@you06 you06 requested review from cfzjywxk and zyguan November 6, 2025 03:10
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 6, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 6, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 6, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-06 08:29:17.877298638 +0000 UTC m=+345207.320328517: ☑️ agreed by zyguan.
  • 2025-11-06 08:38:02.08016024 +0000 UTC m=+345731.523190129: ☑️ agreed by cfzjywxk.

@zyguan zyguan mentioned this pull request Nov 6, 2025
13 tasks
@cfzjywxk cfzjywxk merged commit 795f22b into tikv:tikv-8.5-with-shared-lock Nov 7, 2025
2 of 3 checks passed
you06-pingcap pushed a commit to you06/tikv that referenced this pull request Nov 27, 2025
* implement Lock encode/decode

Signed-off-by: you06 <you1474600@gmail.com>

* remove unused functions

Signed-off-by: you06 <you1474600@gmail.com>

* remove Mutation::Shared & fix clippy

Signed-off-by: you06 <you1474600@gmail.com>

* fmt

Signed-off-by: you06 <you1474600@gmail.com>

---------

Signed-off-by: you06 <you1474600@gmail.com>
you06 added a commit to you06/tikv that referenced this pull request Dec 18, 2025
Signed-off-by: you06 <you1474600@gmail.com>
you06-pingcap pushed a commit to you06/tikv that referenced this pull request Dec 25, 2025
Signed-off-by: you06 <you1474600@gmail.com>
you06-pingcap pushed a commit to you06/tikv that referenced this pull request Dec 26, 2025
Signed-off-by: you06 <you1474600@gmail.com>

split Lock

Signed-off-by: you06 <you1474600@gmail.com>

split Lock and SharedLocks into 2 types definition

Signed-off-by: you06 <you1474600@gmail.com>

remove unused changes

Signed-off-by: you06 <you1474600@gmail.com>

fix build & clippy

Signed-off-by: you06 <you1474600@gmail.com>

format code

Signed-off-by: you06 <you1474600@gmail.com>

refactor

Signed-off-by: you06 <you1474600@gmail.com>

simplify code

Signed-off-by: you06 <you1474600@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants