Skip to content

*: Reduce frequency of store size reporting#18956

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
v01dstar:increase-stats-interval
Sep 18, 2025
Merged

*: Reduce frequency of store size reporting#18956
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
v01dstar:increase-stats-interval

Conversation

@v01dstar
Copy link
Member

@v01dstar v01dstar commented Sep 16, 2025

What is changed and how it works?

Issue Number: Close #18955

What's Changed:

Reduce frequency of store size reporting

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. labels Sep 16, 2025
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2025
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 16, 2025
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Connor1996,overvenus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 18, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-16 21:45:09.639805106 +0000 UTC m=+1002576.199686613: ☑️ agreed by Connor1996.
  • 2025-09-18 06:21:14.202972615 +0000 UTC m=+80835.681553312: ☑️ agreed by overvenus.

@v01dstar
Copy link
Member Author

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 8668d9c into tikv:master Sep 18, 2025
9 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Sep 18, 2025
@v01dstar v01dstar deleted the increase-stats-interval branch September 19, 2025 01:57
@v01dstar v01dstar added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Sep 19, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Sep 19, 2025
close tikv#18955

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18976.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18977.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #18978.

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Sep 24, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Sep 25, 2025
close #18955

Reduce frequency of store size reporting

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

Co-authored-by: Yang Zhang <yang.zhang@pingcap.com>
3AceShowHand pushed a commit to 3AceShowHand/tikv that referenced this pull request Oct 13, 2025
close tikv#18955

Reduce frequency of store size reporting

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overly frequent storage stats reporting causing high tail latency when dataset is large

4 participants