Skip to content

aws: disable stalled stream protection for S3Storage#18875

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
kennytm:disable-stalled-stream-protection
Sep 19, 2025
Merged

aws: disable stalled stream protection for S3Storage#18875
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
kennytm:disable-stalled-stream-protection

Conversation

@kennytm
Copy link
Contributor

@kennytm kennytm commented Aug 22, 2025

What is changed and how it works?

Issue Number: Close #18846

What's Changed:


Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Reduced chance of BR restore failure from S3-compatible storage when the S3 server limits bandwidth through traffic shaping.

@kennytm kennytm added the component/backup-restore Component: backup, import, external_storage label Aug 22, 2025
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 22, 2025
Signed-off-by: kennytm <kennytm@gmail.com>
@kennytm kennytm force-pushed the disable-stalled-stream-protection branch from 377a1b3 to 8202691 Compare August 22, 2025 08:24
@kennytm
Copy link
Contributor Author

kennytm commented Aug 22, 2025

PTAL @Leavrth

@kennytm
Copy link
Contributor Author

kennytm commented Aug 28, 2025

/run-check-issue-triage-complete

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-22 08:06:46.346780411 +0000 UTC m=+600014.289955917: ☑️ agreed by YuJuncen.
  • 2025-09-19 02:49:54.602859058 +0000 UTC m=+154556.081439735: ☑️ agreed by Leavrth.

@kennytm
Copy link
Contributor Author

kennytm commented Sep 19, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit 2198165 into tikv:master Sep 19, 2025
9 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Sep 19, 2025
@YuJuncen YuJuncen added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Sep 19, 2025
@YuJuncen
Copy link
Contributor

/run-cherry-picker

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Sep 19, 2025
close tikv#18846

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #18979.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Sep 22, 2025
close #18846

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: kennytm <kennytm@gmail.com>

Co-authored-by: kennytm <kennytm@gmail.com>
LykxSassinator added a commit to LykxSassinator/tikv that referenced this pull request Oct 11, 2025
) (tikv#18979)"

This reverts commit 518cb06.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
3AceShowHand pushed a commit to 3AceShowHand/tikv that referenced this pull request Oct 13, 2025
close tikv#18846

Signed-off-by: kennytm <kennytm@gmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved component/backup-restore Component: backup, import, external_storage dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BR restore / S3: Stalled stream protection interferes with QoS-based rate limiting

4 participants