Skip to content

sst_importer: print the source chain for Error::CannotReadExternalStorage#18845

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
kennytm:streaming_error_details
Sep 22, 2025
Merged

sst_importer: print the source chain for Error::CannotReadExternalStorage#18845
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
kennytm:streaming_error_details

Conversation

@kennytm
Copy link
Contributor

@kennytm kennytm commented Aug 19, 2025

What is changed and how it works?

Issue Number: Close #18840

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Executed the instructions in #18840 and get the following WARN log. Note the additional message after "streaming error".

[2025/08/19 14:50:42.692 +08:00] [WARN] [sst_importer.rs:425] ["download failed"] [err="Cannot read http://127.0.0.1:9001/backup//1/16_61_10828033e81c46d84886eb5810b2733f323ed94f50687970b83a6d58608a9a85_1755253693331_write.sst into /data/UuIemUj/tikv-0/data/import/.temp/57879d23-6408-4c81-9623-b84f7dc28f3d_136_1_64_write_2.sst: streaming error: minimum throughput was specified at 1 B/s, but throughput of 0 B/s was observed"] [name=1/16_61_10828033e81c46d84886eb5810b2733f323ed94f50687970b83a6d58608a9a85_1755253693331_write.sst] [meta="uuid: 57879D2364084C819623B84F7DC28F3D range { start: 7480000000000000725F72 end: 7480000000000000725F72FFFFFFFFFFFFFFFFFFFF } length: 1851 cf_name: \"write\" region_id: 136 region_epoch { conf_ver: 1 version: 64 } cipher_iv: 43ADF7FC07210995D453C838574BD757"] [thread_id=129]

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@kennytm
sst_importer: print the source chain for Error::CannotReadExternalSto…
9874632 
…rage

Signed-off-by: kennytm <kennytm@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 19, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 27, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 19, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 19, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-27 03:37:28.644797855 +0000 UTC m=+324940.522628799: ☑️ agreed by hbisheng.
  • 2025-09-19 06:01:58.739200854 +0000 UTC m=+166080.217781511: ☑️ agreed by Leavrth.

@kennytm
Copy link
Contributor Author

kennytm commented Sep 19, 2025

/run-check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed do-not-merge/needs-triage-completed labels Sep 19, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, Leavrth, overvenus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 22, 2025
@ti-chi-bot ti-chi-bot bot merged commit e893d7e into tikv:master Sep 22, 2025
9 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Sep 22, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #18987.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 22, 2025
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Sep 23, 2025
@ti-chi-bot @kennytm
sst_importer: print the source chain for Error::CannotReadExternalSto…
bda98e6 
…rage (#18845) (#18987)

close #18840

Signed-off-by: kennytm <kennytm@gmail.com>

Co-authored-by: kennytm <kennytm@gmail.com>
3AceShowHand pushed a commit to 3AceShowHand/tikv that referenced this pull request Oct 13, 2025
@kennytm @3AceShowHand
sst_importer: print the source chain for Error::CannotReadExternalSto…
a359e09 
…rage (tikv#18845)

close tikv#18840

Signed-off-by: kennytm <kennytm@gmail.com>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

+2 more reviewers

@hbisheng hbisheng hbisheng approved these changes

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

BR restore / S3: details about "streaming error" is not printed.

5 participants

@kennytm @ti-chi-bot @overvenus @hbisheng @Leavrth