Skip to content

resolve: returns StoreTombstone directly if PD returns store not found. (#18023)#18786

Open
ti-chi-bot wants to merge 2 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18023-to-release-8.5
Open

resolve: returns StoreTombstone directly if PD returns store not found. (#18023)#18786
ti-chi-bot wants to merge 2 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18023-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 5, 2025

This is an automated cherry-pick of #18023

What is changed and how it works?

Issue Number: Close #17875

What's Changed:

This PR optimizes the error handling progress when resolving address returns
by the response from PD. 

If the response contains `store xxx not found`, the resolver could directly returns
the `StoreTombstone` Error to make the raft-client end the retrying loop quickly.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

This PR optimizes the error handling progress when resolving address returns
by the response from PD.

@LykxSassinator @ti-chi-bot
reolve: returns StoreTombstone if PD returns store not found.
ce9f5df 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator @ti-chi-bot
Add annotations.
930692f 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Aug 5, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 5, 2025
Merged
9 tasks
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 5, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 7, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-07 04:05:15.36808116 +0000 UTC m=+500225.510842334: ☑️ agreed by LykxSassinator.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 7, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 16, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-check-deps 930692f link true /test pull-check-deps

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LykxSassinator LykxSassinator LykxSassinator approved these changes

Assignees

@LykxSassinator LykxSassinator

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ti-chi-bot @LykxSassinator