Skip to content

resolve: returns StoreTombstone directly if PD returns store not found.#18023

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
LykxSassinator:avoid_endless_loop
Dec 18, 2024
Merged

resolve: returns StoreTombstone directly if PD returns store not found.#18023
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
LykxSassinator:avoid_endless_loop

Conversation

@LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Dec 18, 2024 •
edited
Loading

What is changed and how it works?

Issue Number: Close #17875

What's Changed:

This PR optimizes the error handling progress when resolving address returns
by the response from PD. 

If the response contains `store xxx not found`, the resolver could directly returns
the `StoreTombstone` Error to make the raft-client end the retrying loop quickly.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

This PR optimizes the error handling progress when resolving address returns
by the response from PD.

@LykxSassinator
reolve: returns StoreTombstone if PD returns store not found.
5b76213 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Dec 18, 2024
@LykxSassinator
Add annotations.
a402494 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Dec 18, 2024

/check-issue-triage-complete

Connor1996
Connor1996 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 18, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, glorv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-18 07:27:32.782733835 +0000 UTC m=+1028242.871536625: ☑️ agreed by Connor1996.
  • 2024-12-18 09:00:59.213629522 +0000 UTC m=+1033849.302432076: ☑️ agreed by glorv.

@ti-chi-bot ti-chi-bot bot merged commit 066dcfd into tikv:master Dec 18, 2024
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Dec 18, 2024
@LykxSassinator LykxSassinator deleted the avoid_endless_loop branch December 18, 2024 09:16
@LykxSassinator LykxSassinator mentioned this pull request Dec 18, 2024
Closed
@glorv glorv mentioned this pull request May 7, 2025
Closed
@LykxSassinator LykxSassinator added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Aug 5, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 5, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #18786.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 5, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glorv glorv glorv approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

resolving tikv store address return an error "invalid store ID xxxx, not found" leading to raft client infinite loop

4 participants

@LykxSassinator @ti-chi-bot @glorv @Connor1996