Skip to content

region-size: Inherit relevant configs on region-size from the last config file.#18505

Merged
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
LykxSassinator:inherit_region_configs
Jun 13, 2025
Merged

region-size: Inherit relevant configs on region-size from the last config file.#18505
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
LykxSassinator:inherit_region_configs

Conversation

@LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Jun 4, 2025 •
edited
Loading

What is changed and how it works?

Issue Number: Close #18503

What's Changed:

This PR introduces an inheritance mechanism for region-size configurations to ensure smooth
upgrades from earlier versions to v8.5+. When upgrading, the system will automatically retain
the previous region-size settings unless they were manually modified in the current tikv.toml
before startup.

image

Make TiKV can inherit the last configurations on `region-size` to avoid change the default size
of region unexpectedly.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Make TiKV can inherit the last configurations on `region-size` to avoid change the default size
of region unexpectedly.

@LykxSassinator
tikv_util: add basic extentions for configurable values.
5da136c 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Polish codes and add uts.
b3fd7d1 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 4, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2025
@LykxSassinator LykxSassinator marked this pull request as ready for review June 4, 2025 08:59
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue labels Jun 4, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 4, 2025
overvenus
overvenus reviewed Jun 4, 2025
View reviewed changes
@LykxSassinator
Polish annotations.
d94d5b4 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 12, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-04 09:03:48.580602051 +0000 UTC m=+432514.782947316: ☑️ agreed by bufferflies.
  • 2025-06-12 04:09:59.781093748 +0000 UTC m=+500978.009409013: ☑️ agreed by overvenus.

zhangjinpeng87
zhangjinpeng87 approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, overvenus, zhangjinpeng87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 13, 2025
@ti-chi-bot ti-chi-bot bot merged commit 63867c3 into tikv:master Jun 13, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Jun 13, 2025
@LykxSassinator LykxSassinator added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jun 13, 2025
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 13, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #18545.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 13, 2025
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jul 3, 2025
@ti-chi-bot @LykxSassinator
region-size: Inherit relevant configs on region-size from the last co…
84610a2 
…nfig file. (#18505) (#18545)

close #18503

Make TiKV can inherit the last configurations on `region-size` to avoid change the default size
of region unexpectedly.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>

Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator LykxSassinator mentioned this pull request Jul 3, 2025
Merged
9 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 3, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@zhangjinpeng87 zhangjinpeng87 zhangjinpeng87 approved these changes

@bufferflies bufferflies bufferflies approved these changes

@Connor1996 Connor1996 Awaiting requested review from Connor1996

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

region-size: Inherit last configured settings instead of default values

5 participants

@LykxSassinator @ti-chi-bot @overvenus @zhangjinpeng87 @bufferflies