GC: remove compact on split#18500
Merged
ti-chi-bot[bot] merged 4 commits intotikv:masterfrom Jul 7, 2025
Merged
Conversation
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Contributor
|
Skipping CI for Draft Pull Request. |
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
Member
|
bugbot run |
There was a problem hiding this comment.
✅ BugBot reviewed your changes and found no bugs!
BugBot free trial expires on July 22, 2025
You have used $0.00 of your $10.00 spend limit so far. Manage your spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
Contributor
|
bugbot run |
hbisheng
approved these changes
Jul 4, 2025
LykxSassinator
approved these changes
Jul 7, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbisheng, LykxSassinator The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Jul 21, 2025
close tikv#18451 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Jul 21, 2025
close tikv#18451 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
9 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Jul 21, 2025
close tikv#18451 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
9 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Jul 23, 2025
close #18451 Remove compaction scheduling on split key not found error. Split key not found error is usually returned when a region only has a few keys but a large number of stale MVCC versions. This was the incentive of scheduling a compaction on split error. However, this solution brings a more serious problem, i.e. worker threads starvation. We don't really need this extra compaction, we expect that, after the compaction optimization is done, this MVCC accumulation issue would be mitigated. So, once the "split key not found" occurs, we just rely on the CheckThenCompact to resolve it. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Yang Zhang <yang.zhang@pingcap.com> Co-authored-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
added a commit
to ti-chi-bot/tikv
that referenced
this pull request
Aug 5, 2025
close tikv#18451 Remove compaction scheduling on split key not found error. Split key not found error is usually returned when a region only has a few keys but a large number of stale MVCC versions. This was the incentive of scheduling a compaction on split error. However, this solution brings a more serious problem, i.e. worker threads starvation. We don't really need this extra compaction, we expect that, after the compaction optimization is done, this MVCC accumulation issue would be mitigated. So, once the "split key not found" occurs, we just rely on the CheckThenCompact to resolve it. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
added a commit
to ti-chi-bot/tikv
that referenced
this pull request
Aug 5, 2025
close tikv#18451 Remove compaction scheduling on split key not found error. Split key not found error is usually returned when a region only has a few keys but a large number of stale MVCC versions. This was the incentive of scheduling a compaction on split error. However, this solution brings a more serious problem, i.e. worker threads starvation. We don't really need this extra compaction, we expect that, after the compaction optimization is done, this MVCC accumulation issue would be mitigated. So, once the "split key not found" occurs, we just rely on the CheckThenCompact to resolve it. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
added a commit
to ti-chi-bot/tikv
that referenced
this pull request
Sep 16, 2025
close tikv#18451 Remove compaction scheduling on split key not found error. Split key not found error is usually returned when a region only has a few keys but a large number of stale MVCC versions. This was the incentive of scheduling a compaction on split error. However, this solution brings a more serious problem, i.e. worker threads starvation. We don't really need this extra compaction, we expect that, after the compaction optimization is done, this MVCC accumulation issue would be mitigated. So, once the "split key not found" occurs, we just rely on the CheckThenCompact to resolve it. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
added a commit
to ti-chi-bot/tikv
that referenced
this pull request
Sep 16, 2025
close tikv#18451 Remove compaction scheduling on split key not found error. Split key not found error is usually returned when a region only has a few keys but a large number of stale MVCC versions. This was the incentive of scheduling a compaction on split error. However, this solution brings a more serious problem, i.e. worker threads starvation. We don't really need this extra compaction, we expect that, after the compaction optimization is done, this MVCC accumulation issue would be mitigated. So, once the "split key not found" occurs, we just rely on the CheckThenCompact to resolve it. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
added a commit
to ti-chi-bot/tikv
that referenced
this pull request
Sep 16, 2025
close tikv#18451 Remove compaction scheduling on split key not found error. Split key not found error is usually returned when a region only has a few keys but a large number of stale MVCC versions. This was the incentive of scheduling a compaction on split error. However, this solution brings a more serious problem, i.e. worker threads starvation. We don't really need this extra compaction, we expect that, after the compaction optimization is done, this MVCC accumulation issue would be mitigated. So, once the "split key not found" occurs, we just rely on the CheckThenCompact to resolve it. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
added a commit
to ti-chi-bot/tikv
that referenced
this pull request
Sep 16, 2025
close tikv#18451 Remove compaction scheduling on split key not found error. Split key not found error is usually returned when a region only has a few keys but a large number of stale MVCC versions. This was the incentive of scheduling a compaction on split error. However, this solution brings a more serious problem, i.e. worker threads starvation. We don't really need this extra compaction, we expect that, after the compaction optimization is done, this MVCC accumulation issue would be mitigated. So, once the "split key not found" occurs, we just rely on the CheckThenCompact to resolve it. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
added a commit
to ti-chi-bot/tikv
that referenced
this pull request
Sep 16, 2025
close tikv#18451 Remove compaction scheduling on split key not found error. Split key not found error is usually returned when a region only has a few keys but a large number of stale MVCC versions. This was the incentive of scheduling a compaction on split error. However, this solution brings a more serious problem, i.e. worker threads starvation. We don't really need this extra compaction, we expect that, after the compaction optimization is done, this MVCC accumulation issue would be mitigated. So, once the "split key not found" occurs, we just rely on the CheckThenCompact to resolve it. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
added a commit
to ti-chi-bot/tikv
that referenced
this pull request
Sep 17, 2025
close tikv#18451 Remove compaction scheduling on split key not found error. Split key not found error is usually returned when a region only has a few keys but a large number of stale MVCC versions. This was the incentive of scheduling a compaction on split error. However, this solution brings a more serious problem, i.e. worker threads starvation. We don't really need this extra compaction, we expect that, after the compaction optimization is done, this MVCC accumulation issue would be mitigated. So, once the "split key not found" occurs, we just rely on the CheckThenCompact to resolve it. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Sep 17, 2025
close #18451 Remove compaction scheduling on split key not found error. Split key not found error is usually returned when a region only has a few keys but a large number of stale MVCC versions. This was the incentive of scheduling a compaction on split error. However, this solution brings a more serious problem, i.e. worker threads starvation. We don't really need this extra compaction, we expect that, after the compaction optimization is done, this MVCC accumulation issue would be mitigated. So, once the "split key not found" occurs, we just rely on the CheckThenCompact to resolve it. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com> Co-authored-by: Yang Zhang <yang.zhang@pingcap.com>
v01dstar
added a commit
to ti-chi-bot/tikv
that referenced
this pull request
Sep 30, 2025
close tikv#18451 Remove compaction scheduling on split key not found error. Split key not found error is usually returned when a region only has a few keys but a large number of stale MVCC versions. This was the incentive of scheduling a compaction on split error. However, this solution brings a more serious problem, i.e. worker threads starvation. We don't really need this extra compaction, we expect that, after the compaction optimization is done, this MVCC accumulation issue would be mitigated. So, once the "split key not found" occurs, we just rely on the CheckThenCompact to resolve it. Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #18451
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note