txn_status_cache: avoid deadlock in txn_status_cache with Pipelined DML#18385
Merged
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom Apr 15, 2025
Merged
Conversation
Signed-off-by: ekexium <eke@fastmail.com>
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/storage/txn/txn_status_cache.rs:494
- [nitpick] The fail_point identifier 'txn_status_cache_upsert_after_normal_before_large' is misleading given that the locks are now acquired in the order (large then normal). Consider renaming it to something like 'txn_status_cache_upsert_after_lock_acquisition' for clarity.
fail_point!("txn_status_cache_upsert_after_normal_before_large");
src/storage/txn/txn_status_cache.rs:1562
- Using a fixed sleep duration to wait for threads to reach failpoints might be unreliable. Consider using a synchronization primitive (e.g., a barrier or a notification mechanism) to ensure both threads have reached the intended state before removing the failpoints.
thread::sleep(Duration::from_millis(300));
MyonKeminta
reviewed
Apr 11, 2025
cfzjywxk
approved these changes
Apr 11, 2025
Signed-off-by: ekexium <eke@fastmail.com>
d5d0147 to
c3d754d
Compare
Contributor
Author
|
/retest |
MyonKeminta
approved these changes
Apr 15, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, MyonKeminta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #18384
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note