Skip to content

importer: fixing the import block issue when on cloud (#18330)#18334

Merged
ti-chi-bot[bot] merged 1 commit intotikv:release-9.0-beta.1from
ti-chi-bot:cherry-pick-18330-to-release-9.0-beta.1
Mar 21, 2025
Merged

importer: fixing the import block issue when on cloud (#18330)#18334
ti-chi-bot[bot] merged 1 commit intotikv:release-9.0-beta.1from
ti-chi-bot:cherry-pick-18330-to-release-9.0-beta.1

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #18330

What is changed and how it works?

Issue Number: Close #18328

What's Changed:

  1. Fixed an issue where block_in_place yields on the current thread, but other threads attempt to acquire the DashMap lock, potentially causing a deadlock.
  2. This issue is more likely to occur in cloud environments with constrained threading models.
importer: fixing the import block issue when on cloud

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

close tikv#18328

importer: fixing the import block issue when on cloud

Signed-off-by: 3pointer <luancheng@pingcap.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1 labels Mar 21, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 21, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 21, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-21 09:55:45.471888344 +0000 UTC m=+608639.156124425: ☑️ agreed by 3pointer.
  • 2025-03-21 09:56:31.876525081 +0000 UTC m=+608685.560761176: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 21, 2025
@ti-chi-bot ti-chi-bot bot merged commit 0a97ca8 into tikv:release-9.0-beta.1 Mar 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants