*: Fix incorrect mapped allocation per thread metric#18126
Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom Jan 18, 2025
Merged
*: Fix incorrect mapped allocation per thread metric#18126ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
Conversation
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
hbisheng
approved these changes
Jan 15, 2025
Member
hbisheng
left a comment
There was a problem hiding this comment.
Would be great if we can test this by running BR in a test environment and checking the metrics.
glorv
approved these changes
Jan 15, 2025
Contributor
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, hbisheng, v01dstar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/test |
Contributor
|
@v01dstar: The The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
|
/test pull-unit-test |
xzhangxian1008
pushed a commit
to xzhangxian1008/tikv
that referenced
this pull request
Feb 8, 2025
close tikv#18125 Fix incorrect mapped allocation per thread metric Not all thread builders are hooked by `thread_allocate_exclusive_arena`, so some threads are using shared arena, causing incorrect per thread allocation. Signed-off-by: Connor1996 <zbk602423539@gmail.com> Signed-off-by: xzhangxian1008 <xzhangxian@foxmail.com>
ti-chi-bot
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Feb 11, 2025
close tikv#18125 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
9 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
close #18125 Fix incorrect mapped allocation per thread metric Not all thread builders are hooked by `thread_allocate_exclusive_arena`, so some threads are using shared arena, causing incorrect per thread allocation. Signed-off-by: Connor1996 <zbk602423539@gmail.com> Co-authored-by: Connor1996 <zbk602423539@gmail.com>
Contributor
|
/cherry-pick release-7.5 |
Member
|
@hhwyt: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Jun 18, 2025
close tikv#18125 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
9 tasks
hhwyt
pushed a commit
to hhwyt/tikv
that referenced
this pull request
Jun 19, 2025
close tikv#18125 Fix incorrect mapped allocation per thread metric Not all thread builders are hooked by `thread_allocate_exclusive_arena`, so some threads are using shared arena, causing incorrect per thread allocation. Signed-off-by: Connor1996 <zbk602423539@gmail.com> (cherry picked from commit 18f4419)
hhwyt
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Jun 19, 2025
close tikv#18125 Fix incorrect mapped allocation per thread metric Not all thread builders are hooked by `thread_allocate_exclusive_arena`, so some threads are using shared arena, causing incorrect per thread allocation. Signed-off-by: Connor1996 <zbk602423539@gmail.com> (cherry picked from commit 18f4419)
hhwyt
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Jun 19, 2025
close tikv#18125 Fix incorrect mapped allocation per thread metric Not all thread builders are hooked by `thread_allocate_exclusive_arena`, so some threads are using shared arena, causing incorrect per thread allocation. Signed-off-by: Connor1996 <zbk602423539@gmail.com> (cherry picked from commit 18f4419) Signed-off-by: hhwyt <hhwyt1@gmail.com>
ekexium
pushed a commit
to ekexium/tikv
that referenced
this pull request
Jul 11, 2025
close tikv#18125 Fix incorrect mapped allocation per thread metric Not all thread builders are hooked by `thread_allocate_exclusive_arena`, so some threads are using shared arena, causing incorrect per thread allocation. Signed-off-by: Connor1996 <zbk602423539@gmail.com> (cherry picked from commit 18f4419) Signed-off-by: hhwyt <hhwyt1@gmail.com>
hhwyt
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Jul 11, 2025
close tikv#18125 Fix incorrect mapped allocation per thread metric Not all thread builders are hooked by `thread_allocate_exclusive_arena`, so some threads are using shared arena, causing incorrect per thread allocation. Signed-off-by: Connor1996 <zbk602423539@gmail.com> (cherry picked from commit 18f4419) Signed-off-by: hhwyt <hhwyt1@gmail.com>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
close #18125 Fix incorrect mapped allocation per thread metric Not all thread builders are hooked by `thread_allocate_exclusive_arena`, so some threads are using shared arena, causing incorrect per thread allocation. Signed-off-by: Connor1996 <zbk602423539@gmail.com> Signed-off-by: hhwyt <hhwyt1@gmail.com> Co-authored-by: Connor <zbk602423539@gmail.com>
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Jul 16, 2025
close #18125 Fix incorrect mapped allocation per thread metric Not all thread builders are hooked by `thread_allocate_exclusive_arena`, so some threads are using shared arena, causing incorrect per thread allocation. Signed-off-by: Connor1996 <zbk602423539@gmail.com> Co-authored-by: Connor1996 <zbk602423539@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #18125
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note