Skip to content

server: print more information when default not found error is encountered#18066

Merged
ti-chi-bot[bot] merged 4 commits intotikv:masterfrom
cfzjywxk:more_info_not_found
Dec 30, 2024
Merged

server: print more information when default not found error is encountered#18066
ti-chi-bot[bot] merged 4 commits intotikv:masterfrom
cfzjywxk:more_info_not_found

Conversation

@cfzjywxk
Copy link
Collaborator

@cfzjywxk cfzjywxk commented Dec 26, 2024

What is changed and how it works?

Issue Number: Close #18065

The coprocessor path log is like:

[ERRO] default not found in coprocessor request processing, reqCtx: ReqContext { tag: select, context: region_id: 1 region_epoch { conf_ver: 1 version: 1 } peer { id: 1 store_id: 1 }, ranges: [start: 7480000000000000055F728000000000000001 end: 7480000000000000055F728000000000000003], deadline: Deadline { deadline: MonotonicCoarse(Timespec { sec: 44231, nsec: 825857275 }) }, peer: Some("ipv4:127.0.0.1:48380"), is_desc_scan: Some(false), txn_start_ts: TimeStamp(6), bypass_locks: Empty, access_locks: Empty, cache_match_version: None, lower_bound: [116, 128, 0, 0, 0, 0, 0, 0, 5, 95, 114, 128, 0, 0, 0, 0, 0, 0, 1], upper_bound: [116, 128, 0, 0, 0, 0, 0, 0, 5, 95, 114, 128, 0, 0, 0, 0, 0, 0, 3], perf_level: Uninitialized, allowed_in_flashback: false }, err: default not found: key:7480000000000000FF055F728000000000FF0000020000000000FAFFFFFFFFFFFFFFFB, maybe read truncated/dropped table data?, thread_id: 132

With request context information.

The storage get and batch-get log is like:

[ERRO] default not found in storage get, RpcContext: region_id: 1 region_epoch { conf_ver: 1 version: 1 } peer { id: 1 store_id: 1 }, err: default not found: key:7480000000000000FF055F728000000000FF0000020000000000FAFFFFFFFFFFFFFFFB, maybe read truncated/dropped table data?, thread_id: 18

With RPC context information.

With call stack information, like

 1: tikv::storage::mvcc::reader::point_getter::PointGetter<S>::load_data_from_default_cf::{{closure}}
             at src/storage/mvcc/reader/point_getter.rs:369:13
   2: core::option::Option<T>::map
             at /rustc/89e2160c4ca5808657ed55392620ed1dbbce78d1/library/core/src/option.rs:1072:29
   3: fail::eval
             at src/index.crates.io-6f17d22bba15001f/fail-0.5.1/src/lib.rs:643:5
   4: tikv::storage::mvcc::reader::point_getter::PointGetter<S>::load_data_from_default_cf
             at src/storage/mvcc/reader/point_getter.rs:368:9
   5: tikv::storage::mvcc::reader::point_getter::PointGetter<S>::load_data
             at src/storage/mvcc/reader/point_getter.rs:308:41
   6: tikv::storage::mvcc::reader::point_getter::PointGetter<S>::get
             at src/storage/mvcc/reader/point_getter.rs:181:9
   7: <tikv::storage::txn::store::SnapshotStore<S> as tikv::storage::txn::store::Store>::get
             at src/storage/txn/store.rs:306:17
   8: tikv::storage::Storage<E,L,F>::get::{{closure}}::{{closure}}

What's Changed:

Print more information in logs when default not found error is encounterred.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@cfzjywxk cfzjywxk added the type/enhancement The issue or PR belongs to an enhancement. label Dec 26, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 26, 2024
@cfzjywxk cfzjywxk requested a review from you06 December 27, 2024 03:36
ekexium
ekexium reviewed Dec 27, 2024
View reviewed changes
Copy link
Contributor

@ekexium ekexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@cfzjywxk
print more information in logs when default not found error is encoun…
54a5633 
…terred

Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
@cfzjywxk cfzjywxk force-pushed the more_info_not_found branch from 0da4ec0 to 54a5633 Compare December 27, 2024 07:59
@cfzjywxk
format
d83ead4 
Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2024
@cfzjywxk
format
b91ffdf 
Signed-off-by: cfzjywxk <cfzjywxk@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium, glorv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 30, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-27 08:11:09.180988715 +0000 UTC m=+78804.536993254: ☑️ agreed by ekexium.
  • 2024-12-30 11:27:18.078126972 +0000 UTC m=+349773.434131511: ☑️ agreed by glorv.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2024

@cfzjywxk: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@cfzjywxk
Copy link
Collaborator Author

cfzjywxk commented Dec 30, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 03a5c53 into tikv:master Dec 30, 2024
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glorv glorv glorv approved these changes

@ekexium ekexium ekexium approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

@you06 you06 Awaiting requested review from you06

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

server: add more information when default not found error is encounterred

3 participants

@cfzjywxk @glorv @ekexium