Skip to content

metrics: let panel series overrides compatible with additional group_by#18061

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
glorv:fix-overrides
Dec 26, 2024
Merged

metrics: let panel series overrides compatible with additional group_by#18061
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
glorv:fix-overrides

Conversation

@glorv
Copy link
Contributor

@glorv glorv commented Dec 26, 2024

What is changed and how it works?

Issue Number: Close #18060

What's Changed:

Use regex expression in panel seriesOverrides to let it compatible with the optional "additional_groupby" alias.

Current:

image

After this change:

image

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 26, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 26, 2024
@glorv glorv added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 26, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 26, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbisheng, LykxSassinator

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 26, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-26 05:24:57.867275304 +0000 UTC m=+1712087.956077846: ☑️ agreed by hbisheng.
  • 2024-12-26 12:21:38.223874989 +0000 UTC m=+7433.579879529: ☑️ agreed by LykxSassinator.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2024

@glorv: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@glorv
Copy link
Contributor Author

glorv commented Dec 26, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6ff4b9d into tikv:master Dec 26, 2024
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Dec 26, 2024
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 26, 2024

In response to a cherrypick label: new pull request created to branch release-8.5: #18064.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Dec 26, 2024
@glorv @ti-chi-bot
This is an automated cherry-pick of tikv#18061
55ab3d8 
close tikv#18060

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 26, 2024
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 27, 2024
@ti-chi-bot @glorv
metrics: let panel series overrides compatible with additional group_…
ddbcd54 
…by (#18061) (#18064)

close #18060

Use regex expression in panel seriesOverrides to let it compatible with the optional "additional_groupby" alias.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: glorv <glorvs@163.com>

Co-authored-by: glorv <glorvs@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LykxSassinator LykxSassinator LykxSassinator approved these changes

@overvenus overvenus Awaiting requested review from overvenus

@Connor1996 Connor1996 Awaiting requested review from Connor1996

+1 more reviewer

@hbisheng hbisheng hbisheng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

metrics: raft waterfall's panel is broken

4 participants

@glorv @ti-chi-bot @hbisheng @LykxSassinator