Skip to content

cdc: fix an consistency issue introduced by #17818#18017

Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-7.5from
hicqu:7.5-fix-inconsistent
Dec 18, 2024
Merged

cdc: fix an consistency issue introduced by #17818#18017
ti-chi-bot[bot] merged 2 commits intotikv:release-7.5from
hicqu:7.5-fix-inconsistent

Conversation

@hicqu
Copy link
Contributor

@hicqu hicqu commented Dec 18, 2024

What is changed and how it works?

Issue Number: Close #18016

What's Changed:

cdc: fix an consistency issue introduced by #17818

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@hicqu
fix
8525dd5 
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 18, 2024
@hicqu
Copy link
Contributor Author

hicqu commented Dec 18, 2024

/test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

@hicqu: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test pull-unit-test

The following commands are available to trigger optional jobs:

/debug pull-integration-test

Use /test all to run the following jobs that were automatically triggered:

tikv/tikv/release-7.5/pull_unit_test
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hicqu
Copy link
Contributor Author

hicqu commented Dec 18, 2024

/test pull-unit-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 18, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-18 02:39:57.196778184 +0000 UTC m=+1010987.285580719: ☑️ agreed by 3AceShowHand.
  • 2024-12-18 03:15:04.879840789 +0000 UTC m=+1013094.968643333: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 18, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 18, 2024

@hicqu: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hicqu
Copy link
Contributor Author

hicqu commented Dec 18, 2024

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot merged commit ca5713f into tikv:release-7.5 Dec 18, 2024
@hicqu hicqu deleted the 7.5-fix-inconsistent branch December 18, 2024 06:30
hicqu added a commit to ti-chi-bot/tikv that referenced this pull request Dec 19, 2024
@hicqu @ti-chi-bot
cdc: fix an consistency issue introduced by tikv#17818 (tikv#18017)
bad51c1 
close tikv#18016

cdc: fix an consistency issue introduced by tikv#17818

Signed-off-by: qupeng <qupeng@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
This was referenced Dec 20, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hicqu @3AceShowHand @YuJuncen