Skip to content

cdc: skip loading old values for un-observed ranges#17878

Merged
ti-chi-bot[bot] merged 8 commits intotikv:masterfrom
hicqu:cdc-ob-old-value
Nov 25, 2024
Merged

cdc: skip loading old values for un-observed ranges#17878
ti-chi-bot[bot] merged 8 commits intotikv:masterfrom
hicqu:cdc-ob-old-value

Conversation

@hicqu
Copy link
Contributor

@hicqu hicqu commented Nov 22, 2024

What is changed and how it works?

Issue Number: Close #17877
Issue Number: Close #17876

What's Changed:

cdc: skip loading old values for un-observed ranges

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2024
@hicqu
Copy link
Contributor Author

hicqu commented Nov 22, 2024

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 22, 2024
Copy link
Member

@v01dstar v01dstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 22, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-22 10:14:24.85464134 +0000 UTC m=+199452.474295850: ☑️ agreed by 3AceShowHand.
  • 2024-11-22 23:40:32.031633033 +0000 UTC m=+247819.651287547: ☑️ agreed by v01dstar.

@hicqu
Copy link
Contributor Author

hicqu commented Nov 25, 2024

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, hicqu, v01dstar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 25, 2024
hicqu and others added 4 commits November 25, 2024 11:39
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot merged commit cf749a6 into tikv:master Nov 25, 2024
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Nov 25, 2024
@hicqu hicqu deleted the cdc-ob-old-value branch November 25, 2024 07:25
@hicqu hicqu added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Nov 25, 2024
@hicqu
Copy link
Contributor Author

hicqu commented Nov 25, 2024

/cherry-pick

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17885.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 25, 2024
close tikv#17876, fix tikv#17876, close tikv#17877

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #17886.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #17887.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #17888.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024
close #17876, fix #17876, close #17877

cdc: skip loading old values for un-observed ranges

Signed-off-by: qupeng <qupeng@pingcap.com>

Co-authored-by: qupeng <qupeng@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 3, 2024
close #17876, fix #17876, close #17877

cdc: skip loading old values for un-observed ranges

Signed-off-by: qupeng <qupeng@pingcap.com>

Co-authored-by: qupeng <qupeng@pingcap.com>
hicqu added a commit to ti-chi-bot/tikv that referenced this pull request Dec 19, 2024
…v#17885)

close tikv#17876, fix tikv#17876, close tikv#17877

cdc: skip loading old values for un-observed ranges

Signed-off-by: qupeng <qupeng@pingcap.com>

Co-authored-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

4 participants