Skip to content

[Test-only] Use a separate worker to test KV disk health #17843

Closed
hbisheng wants to merge 12 commits intotikv:masterfrom
hbisheng:pr-17801
Closed

[Test-only] Use a separate worker to test KV disk health #17843
hbisheng wants to merge 12 commits intotikv:masterfrom
hbisheng:pr-17801

Conversation

@hbisheng
Copy link
Member

@hbisheng hbisheng commented Nov 19, 2024

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

LykxSassinator and others added 11 commits November 11, 2024 17:29
@LykxSassinator
[WIP] raftstore: calculate the slow score by considering individual d…
e0e13d7 
…isk performance factors.

Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Add more annotations.
5053d26 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Update metrics.
427f5f0 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Polish codes.
ee70824 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Polish codes and add extra configurations of inspecting kvdb latency.
4172302 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Address comments.
fc110c8 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Add uts.
870c6f1 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Fix bugs.
5b6865f 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Sync logs if there exists inspectors in the ApplyContext.
7cf302f 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@LykxSassinator
Take the apply_wait_duration into account
1498b63 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@hbisheng
Use a separate worker to test KV disk
9baf4e5 
Signed-off-by: Bisheng Huang <hbisheng@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 19, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign niedhui for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 19, 2024
@hbisheng
set a small pending_capacity
05b2d07 
Signed-off-by: Bisheng Huang <hbisheng@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456, multiple issues should use full syntax for each issue and be separated by a comma, like: Issue Number: close #123, ref #456.

📖 For more info, you can check the "Linking issues" section in the CONTRIBUTING.md.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

@hbisheng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test 05b2d07 link true /test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

LykxSassinator added a commit to LykxSassinator/tikv that referenced this pull request Nov 20, 2024
@LykxSassinator
Merge tikv#17843 into current branch.
26632fd 
Signed-off-by: lucasliang <nkcs_lykx@hotmail.com>
@hbisheng
Copy link
Member Author

hbisheng commented Nov 25, 2024

Merged into #17801

@hbisheng hbisheng closed this Nov 25, 2024
@hbisheng hbisheng deleted the pr-17801 branch July 14, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hbisheng @LykxSassinator