test: fix the test failure that clear_regions_in_written may be called twice#17798
Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom Nov 11, 2024
Merged
test: fix the test failure that clear_regions_in_written may be called twice#17798ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
Conversation
Signed-off-by: glorv <glorvs@163.com>
SpadeA-Tang
approved these changes
Nov 11, 2024
overvenus
approved these changes
Nov 11, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: overvenus, SpadeA-Tang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
Contributor
Author
|
/retest |
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
ti-chi-bot bot
added a commit
that referenced
this pull request
Nov 11, 2024
…d twice (#17798) (#17800) close #17797 If the last call `prepare_for_region` returns `NotInCache`, `clear_written_regions` can be called twice in both `write_impl` and `clear`, which will cause panic. This pr changes `clear_written_regions` to consume `self.written_regions`to avoid this kind of duplicate clear. Signed-off-by: glorv <glorvs@163.com> Co-authored-by: glorv <glorvs@163.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #17797
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note