Skip to content

br: rename limiter to rate_limiter for better readability#17795

Merged
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
Tristan1900:rate-limit-rename
Nov 25, 2024
Merged

br: rename limiter to rate_limiter for better readability#17795
ti-chi-bot[bot] merged 3 commits intotikv:masterfrom
Tristan1900:rate-limit-rename

Conversation

@Tristan1900
Copy link
Contributor

@Tristan1900 Tristan1900 commented Nov 9, 2024 •
edited
Loading

What is changed and how it works?

Issue Number: Close #17796

What's Changed:

rename limiter usage in BR to rate_limiter for better readability

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

NA

@Tristan1900
rename-limiter-for-better-readability
cc720ac 
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 9, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 9, 2024

Hi @Tristan1900. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 9, 2024
@Tristan1900
Copy link
Contributor Author

Tristan1900 commented Nov 18, 2024

/assign @YuJuncen

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 22, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 22, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 22, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-22 03:59:43.543378056 +0000 UTC m=+176971.163032584: ☑️ agreed by YuJuncen.
  • 2024-11-22 14:39:46.345341178 +0000 UTC m=+215373.964995692: ☑️ agreed by Leavrth.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 22, 2024

@Tristan1900: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

@Tristan1900: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YuJuncen
Copy link
Contributor

YuJuncen commented Nov 25, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Nov 25, 2024
@Tristan1900
format
38c407c 
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
@Tristan1900
Copy link
Contributor Author

Tristan1900 commented Nov 25, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 5a47da9 into tikv:master Nov 25, 2024
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@YuJuncen YuJuncen

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

br: rename limiter for better readability

3 participants

@Tristan1900 @YuJuncen @Leavrth