Skip to content

br: rename limiter for better readability  #17796

@Tristan1900

Description

@Tristan1900

Feature Request

In BR cmd user can pass in a rate-limit parameter, and this is passed down to TiKV in full backup to limit the upload rate. However the naming in full backup is limiter which is not very straightforward of what it is limiting, furthermore there is a resource limiter component being used as limiter as well, which is even more confusing.

I suggest to use rate_limiter for rate limiting and resource_limiter to the resource limiter in full backup path. In the sst importer the rate limiter is referred as speed_limiter, I guess it's fine as long as it's not causing confusion.

Metadata

Metadata

Assignees

No one assigned

    Labels

    type/feature-requestCategorizes issue or PR as related to a new feature.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions