resolved-ts: use min_lock_ts-1 as the candidate of resolved-ts#17730
Merged
ti-chi-bot[bot] merged 6 commits intotikv:masterfrom Nov 5, 2024
Merged
resolved-ts: use min_lock_ts-1 as the candidate of resolved-ts#17730ti-chi-bot[bot] merged 6 commits intotikv:masterfrom
ti-chi-bot[bot] merged 6 commits intotikv:masterfrom
Conversation
bd8126f to
3e2c1e9
Compare
Signed-off-by: ekexium <eke@fastmail.com>
3e2c1e9 to
d200ea1
Compare
cfzjywxk
reviewed
Oct 29, 2024
…ual-min-commit-ts
Contributor
Author
|
/retest |
…nt resolved-ts decreasing across TiKV upgrades. Signed-off-by: ekexium <eke@fastmail.com>
953ecb2 to
5e56746
Compare
…ual-min-commit-ts
5e56746 to
8b7a2db
Compare
you06
reviewed
Nov 4, 2024
Co-authored-by: you06 <you1474600@gmail.com> Signed-off-by: ekexium <eke@fastmail.com>
you06
approved these changes
Nov 4, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Contributor
|
@ekexium: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Contributor
Author
|
/retest |
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
ti-chi-bot
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Nov 5, 2024
…17730) close tikv#17728 Use min_lock_ts-1 as the candidate of resolved-ts, to ensure resolved_ts < lock.min_commit_ts( <= commit_ts). Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: you06 <you1474600@gmail.com>
ti-chi-bot bot
added a commit
that referenced
this pull request
Nov 5, 2024
… (#17768) close #17728 Use min_lock_ts-1 as the candidate of resolved-ts, to ensure resolved_ts < lock.min_commit_ts( <= commit_ts). Signed-off-by: ekexium <eke@fastmail.com> Co-authored-by: ekexium <eke@fastmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: you06 <you1474600@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #17728
What's Changed:
The problem
By the definition of resolved-ts, we require:
commit_ts > resolved_ts, if the commit happens after the calculation of the resolved-ts.Our implementation uses min_commit_ts to calculate resolved-ts, so that what we have is:
commit_ts >= min_commit_ts >= resolved_tsresolved_tsmay be equal tocommit_ts, which breaks the definition of resolved-ts.The fix
This PR ensures
min_commit_ts > resolved_tsto fix the problemRelated changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note