Skip to content

txn: heartbeat piggyback update of min_commit_ts#17528

Closed
ekexium wants to merge 9 commits intotikv:masterfrom
ekexium:feat-heartbeat-min-commit-ts
Closed

txn: heartbeat piggyback update of min_commit_ts#17528
ekexium wants to merge 9 commits intotikv:masterfrom
ekexium:feat-heartbeat-min-commit-ts

Conversation

@ekexium
Copy link
Contributor

@ekexium ekexium commented Sep 12, 2024

What is changed and how it works?

Issue Number: ref #17459

What's Changed:

Depends on #17522

Support push min_commit_ts via heartbeat command

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

ekexium added 2 commits August 30, 2024 00:25
@ekexium
feat: introduce large_txn_cache
18822df 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
fix: replace entry when upsert a normal txn entry
847300e 
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 12, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ekexium, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 12, 2024
@ekexium ekexium mentioned this pull request Sep 12, 2024
Closed
@ekexium ekexium force-pushed the feat-heartbeat-min-commit-ts branch from 57925b4 to 5ef0927 Compare September 12, 2024 05:35
@ekexium
address comments
ea44196 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
refine: don't update committed or rolled back txns in normal cache
1eb9a0a 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
update kvproto; move txn_status_cache out of scheduler
4144eca 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
implement broadcast_txn_status for tikv service
edefd67 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
minor fix
c88fd04 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
handle is_completed
d8ff2ab 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
push min_commit_ts in heartbeat command
c334d62 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium force-pushed the feat-heartbeat-min-commit-ts branch from 5ef0927 to c334d62 Compare September 21, 2024 10:51
@ekexium
Copy link
Contributor Author

ekexium commented Sep 25, 2024

This part will be in #17540

@ekexium ekexium closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ekexium