Skip to content

*: Prevent resolved-ts from being blocked by pipelined DML transactions.#17540

Merged
ti-chi-bot[bot] merged 16 commits intotikv:masterfrom
ekexium:feat-resolver-for-p-dml
Sep 25, 2024
Merged

*: Prevent resolved-ts from being blocked by pipelined DML transactions.#17540
ti-chi-bot[bot] merged 16 commits intotikv:masterfrom
ekexium:feat-resolver-for-p-dml

Conversation

@ekexium
Copy link
Contributor

@ekexium ekexium commented Sep 12, 2024 •
edited
Loading

What is changed and how it works?

Issue Number: ref #17459

What's Changed:

Prevent resolved-ts from being blocked by pipelined DML transactions.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 12, 2024
@ekexium ekexium mentioned this pull request Sep 13, 2024
Closed
@ekexium ekexium force-pushed the feat-resolver-for-p-dml branch from f8e2176 to 5646aca Compare September 13, 2024 02:15
@ekexium ekexium force-pushed the feat-resolver-for-p-dml branch from 5646aca to 1f92cf8 Compare September 21, 2024 14:31
@ekexium
Copy link
Contributor Author

ekexium commented Sep 22, 2024

/test all

@ekexium
update kvproto; move txn_status_cache out of scheduler
938437d 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
implement broadcast_txn_status for tikv service
b7202d6 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
minor fix
da9db07 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
handle is_completed
6fa741e 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
push min_commit_ts in heartbeat command
f26be81 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
separate normal txns and large txns in resolver
bb7d445 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
wip: resolve using min_commit_ts for pipelined transactions
00d5b9a 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
fix rebase conflict
fadb09e 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
refactor log_locks
fa917e2 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
pass txn_status_cache to the resolver in backup-steram
3a20ef1 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium
minor refactor
f6835a4 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium force-pushed the feat-resolver-for-p-dml branch from 5df69a3 to c4bb18d Compare September 24, 2024 08:04
@ekexium ekexium changed the title [WIP] resovled-ts: resolve using min_commit_ts for pipelined transactions resovled-ts: resolve using min_commit_ts for pipelined transactions Sep 24, 2024
@ekexium ekexium marked this pull request as ready for review September 24, 2024 08:04
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 24, 2024
@ekexium
update kvproto
15e788d 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium force-pushed the feat-resolver-for-p-dml branch from c4bb18d to 15e788d Compare September 24, 2024 08:07
@ekexium
fix txn_heart_beat test
2db3112 
Signed-off-by: ekexium <eke@fastmail.com>
@ekexium ekexium requested a review from cfzjywxk September 24, 2024 12:05
@ekexium ekexium changed the title resovled-ts: resolve using min_commit_ts for pipelined transactions *: Prevent resolved-ts from being blocked by pipelined DML transactions. Sep 24, 2024
you06
you06 reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@you06 you06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

cfzjywxk
cfzjywxk reviewed Sep 25, 2024
View reviewed changes
@ekexium ekexium requested review from cfzjywxk and you06 September 25, 2024 05:02
This was referenced Sep 25, 2024
Closed
Closed
@ekexium
Copy link
Contributor Author

ekexium commented Sep 25, 2024

/retest

1 similar comment
@ekexium
Copy link
Contributor Author

ekexium commented Sep 25, 2024

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 25, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 25, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 25, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 06:59:58.377299361 +0000 UTC m=+1635668.117723292: ☑️ agreed by cfzjywxk.
  • 2024-09-25 07:27:42.735603261 +0000 UTC m=+1637332.476027200: ☑️ agreed by you06.

@ti-chi-bot ti-chi-bot bot merged commit dccee48 into tikv:master Sep 25, 2024
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@you06 you06 you06 approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

@zyguan zyguan Awaiting requested review from zyguan

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

3 participants

@ekexium @cfzjywxk @you06