Skip to content

backup: support large txn by making scanner ignore safe locks.#17463

Merged
ti-chi-bot[bot] merged 7 commits intotikv:masterfrom
3pointer:backup_ignore_locks
Feb 13, 2025
Merged

backup: support large txn by making scanner ignore safe locks.#17463
ti-chi-bot[bot] merged 7 commits intotikv:masterfrom
3pointer:backup_ignore_locks

Conversation

@3pointer
Copy link
Contributor

@3pointer 3pointer commented Aug 30, 2024 •
edited
Loading

What is changed and how it works?

Issue Number: close #19208
ref pingcap/tidb#53224

What's Changed:
Use bypass locks to build backup scanner. so that backup will ignore some safe locks(commit ts > backup ts).

Backup: support large txn by making scanner ignore safe locks

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Support ignore safe locks during backup.

@3pointer
backup: support large txn bypass locks
ea43afa 
Signed-off-by: 3pointer <luancheng@pingcap.com>
@3pointer
add test case
04d0940 
Signed-off-by: 3pointer <luancheng@pingcap.com>
@3pointer
update case
206df9b 
Signed-off-by: 3pointer <luancheng@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2024
@3pointer
update
ac66c2a 
Signed-off-by: 3pointer <luancheng@pingcap.com>
@3pointer 3pointer changed the title Backup: support large txn by making scanner ignore safe locks. backup: support large txn by making scanner ignore safe locks. Sep 2, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@3pointer 3pointer marked this pull request as ready for review February 8, 2025 05:34
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2025
@3pointer
Copy link
Contributor Author

3pointer commented Feb 8, 2025

/test pull-unit-test

@3pointer
fix clippy
b791845 
Signed-off-by: 3pointer <luancheng@pingcap.com>
@3pointer 3pointer force-pushed the backup_ignore_locks branch from dc501f3 to b791845 Compare February 8, 2025 07:47
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 10, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 11, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-10 03:01:08.627482266 +0000 UTC m=+239111.023704325: ☑️ agreed by Leavrth.
  • 2025-02-11 02:32:51.377720574 +0000 UTC m=+323813.773942635: ☑️ agreed by YuJuncen.

@3pointer 3pointer added the skip-issue-check Indicates that a PR no need to check linked issue. label Feb 12, 2025
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-linked-issue labels Feb 12, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 12, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 12, 2025

@3pointer: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3pointer
Copy link
Contributor Author

3pointer commented Feb 13, 2025

/test pull-unit-test

1 similar comment
@3pointer
Copy link
Contributor Author

3pointer commented Feb 13, 2025

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 9ecb912 into tikv:master Feb 13, 2025
8 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Feb 13, 2025
@3pointer 3pointer deleted the backup_ignore_locks branch February 13, 2025 09:15
@YuJuncen YuJuncen mentioned this pull request Dec 9, 2025
Closed
@Leavrth Leavrth added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 14, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Dec 14, 2025
@3pointer @ti-chi-bot @ti-chi-bot
backup: support large txn by making scanner ignore safe locks. (tikv#…
eb87c42 
…17463)

ref pingcap/tidb#53224

Backup: support large txn by making scanner ignore safe locks

Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 14, 2025

In response to a cherrypick label: new pull request created to branch release-8.5: #19204.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 14, 2025
Merged
9 tasks
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Dec 16, 2025
@ti-chi-bot @3pointer
backup: support large txn by making scanner ignore safe locks. (#17463)…
7b68ada 
… (#19204)

close #19208

Backup: support large txn by making scanner ignore safe locks

Signed-off-by: 3pointer <luancheng@pingcap.com>

Co-authored-by: 3pointer <luancheng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

Shadow issue of https://github.com/pingcap/tidb/issues/53224

4 participants

@3pointer @ti-chi-bot @YuJuncen @Leavrth