Skip to content

dep: Update rusoto to support IMDSv2#17441

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
pingyu:update-rusoto-2b142c1
Aug 27, 2024
Merged

dep: Update rusoto to support IMDSv2#17441
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
pingyu:update-rusoto-2b142c1

Conversation

@pingyu
Copy link
Contributor

@pingyu pingyu commented Aug 27, 2024

What is changed and how it works?

Issue Number: Close #16443

What's Changed:

Update rusoto to support IMDSv2.

Related rusoto PR: tikv/rusoto#8.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Update rusoto to support IMDSv2.

@pingyu
update rusoto to support IMDSv2
11e677b 
Signed-off-by: Ping Yu <yuping@pingcap.cn>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 27, 2024
@pingyu
Copy link
Contributor Author

pingyu commented Aug 27, 2024

/cc @3pointer @YuJuncen

@ti-chi-bot ti-chi-bot bot requested review from 3pointer and YuJuncen August 27, 2024 07:07
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 27, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 27, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-27 07:11:37.578992166 +0000 UTC m=+854292.713442288: ☑️ agreed by 3pointer.
  • 2024-08-27 09:21:53.078006595 +0000 UTC m=+862108.212456716: ☑️ agreed by Leavrth.

@pingyu
Copy link
Contributor Author

pingyu commented Aug 27, 2024

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Leavrth, pingyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0a99919 into tikv:master Aug 27, 2024
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Aug 27, 2024
@YuJuncen
Copy link
Contributor

YuJuncen commented Aug 27, 2024

/approve

@pingyu
Copy link
Contributor Author

pingyu commented Aug 27, 2024

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 27, 2024

@pingyu: new pull request created to branch release-8.1: #17446.

Details

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 27, 2024
Closed
9 tasks
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 1, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jul 1, 2025
@pingyu @ti-chi-bot
This is an automated cherry-pick of tikv#17441
d298561 
close tikv#16443

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 1, 2025

In response to a cherrypick label: new pull request created to branch release-7.5: #18612.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 1, 2025
Merged
9 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jul 9, 2025
@ti-chi-bot @pingyu
dep: Update rusoto to support IMDSv2 (#17441) (#18612)
a8af3a1 
close #16443

Update rusoto to support IMDSv2.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Ping Yu <yuping@pingcap.com>

Co-authored-by: Ping Yu <yuping@pingcap.cn>
Co-authored-by: Ping Yu <yuping@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen Awaiting requested review from YuJuncen

2 more reviewers

@3pointer 3pointer 3pointer approved these changes

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

TiKV aws storage sdk don't support retrieve instance metadata via IMDSv2

5 participants

@pingyu @YuJuncen @ti-chi-bot @3pointer @Leavrth