cdc: re-design delegate and downstream to support partial region subscription better#17274
Conversation
|
/test |
|
@hicqu: The
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-unit-test |
Signed-off-by: qupeng <qupeng@pingcap.com>
pingyu
left a comment
There was a problem hiding this comment.
LGTM~
And I think there is an alternatives.
RawKV CDC is actually forked from TiCDC v5.5, but report its own version v1.x.
So maybe we can change the report version of RawKV CDC as v5.x, and TiKV reject any client with version < v4.0.8 (i.e. the BATCH_RESOLVED_TS is not supported). To make life easier.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: overvenus, pingyu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hicqu: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…cription better (tikv#17274) close tikv#16362 Signed-off-by: qupeng <qupeng@pingcap.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What is changed and how it works?
Issue Number: Close #16362
What's Changed:
DelegateandDownstreamto support partial subscription better:This PR reverts #17228 .
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note