Skip to content

expression: fix casting REAL type to STRING type (#16975)#16998

Closed
ti-chi-bot wants to merge 1 commit intotikv:release-5.4from
ti-chi-bot:cherry-pick-16975-to-release-5.4
Closed

expression: fix casting REAL type to STRING type (#16975)#16998
ti-chi-bot wants to merge 1 commit intotikv:release-5.4from
ti-chi-bot:cherry-pick-16975-to-release-5.4

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented May 11, 2024

This is an automated cherry-pick of #16975

What is changed and how it works?

Issue Number: Close #16974

ref pingcap/tidb#53129

What's Changed:

expression: fix casting REAL type to STRING type
- unify the behavior of converting real types to strings in tidb#53129 and tikv.
- use ryu lib in tikv to implement casting real type to str type.
- `if abs(num) >= 1e15 or (num is not zero and abs(num) < 1e-15)` then use decimal exponent format

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fix the incorrect result when casting REAL type to STRING type

@solotzg @ti-chi-bot
This is an automated cherry-pick of tikv#16975
2720ad1 
close tikv#16974

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request May 11, 2024
Merged
9 tasks
@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels May 11, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 11, 2024

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 11, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gengliqi gengliqi closed this May 28, 2024
@ti-chi-bot ti-chi-bot deleted the cherry-pick-16975-to-release-5.4 branch April 15, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

contribution This PR is from a community contributor. do-not-merge/cherry-pick-not-approved ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @gengliqi @solotzg