Skip to content

cdc: handles unordered prewrites on one same key#16864

Merged
ti-chi-bot[bot] merged 65 commits intotikv:masterfrom
hicqu:incremental-scan-lock-pipeline-dml
Sep 10, 2024
Merged

cdc: handles unordered prewrites on one same key#16864
ti-chi-bot[bot] merged 65 commits intotikv:masterfrom
hicqu:incremental-scan-lock-pipeline-dml

Conversation

@hicqu
Copy link
Contributor

@hicqu hicqu commented Apr 17, 2024

What is changed and how it works?

Issue Number: Close #17502

What's Changed:

add generation field into TiCDC Prewrite events

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

hicqu added 30 commits March 8, 2024 17:09
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
Copy link
Contributor Author

hicqu commented Aug 14, 2024

/retest

Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @ekexium PTAL.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 10, 2024
@MyonKeminta MyonKeminta requested a review from ekexium September 10, 2024 06:20
@hicqu hicqu changed the title cdc: support pipelined dml cdc: handles unordered prewrites on one same key Sep 10, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, MyonKeminta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 10, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-10 06:20:08.793966359 +0000 UTC m=+337278.534390298: ☑️ agreed by MyonKeminta.
  • 2024-09-10 07:51:09.032972232 +0000 UTC m=+342738.773396189: ☑️ agreed by 3AceShowHand.

@hicqu
Copy link
Contributor Author

hicqu commented Sep 10, 2024

/retest

2 similar comments
@hicqu
Copy link
Contributor Author

hicqu commented Sep 10, 2024

/retest

@hicqu
Copy link
Contributor Author

hicqu commented Sep 10, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit d99bd9b into tikv:master Sep 10, 2024
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Sep 10, 2024
@hicqu hicqu deleted the incremental-scan-lock-pipeline-dml branch September 11, 2024 03:17
3AceShowHand added a commit to 3AceShowHand/tikv that referenced this pull request Nov 4, 2025
3AceShowHand added a commit to 3AceShowHand/tikv that referenced this pull request Nov 4, 2025
This reverts commit d99bd9b.

Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 7, 2025
close #19083

* revert #16864 to avoid the TiKV-CDC panic due to assertion failed

Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Nov 10, 2025
close #19083

* revert #16864 to avoid the TiKV-CDC panic due to assertion failed

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>

Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>
Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>
rxdoi pushed a commit to rxdoi/tikv that referenced this pull request Nov 18, 2025
close tikv#19083

* revert tikv#16864 to avoid the TiKV-CDC panic due to assertion failed

Signed-off-by: 3AceShowHand <jinl1037@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prewrite generation should be sent to TiCDC

4 participants