Skip to content

statistics: move analyze context out#16481

Merged
ti-chi-bot[bot] merged 6 commits intotikv:masterfrom
0xPoe:rustin-patch-analyze-context
Feb 2, 2024
Merged

statistics: move analyze context out#16481
ti-chi-bot[bot] merged 6 commits intotikv:masterfrom
0xPoe:rustin-patch-analyze-context

Conversation

@0xPoe
Copy link
Member

@0xPoe 0xPoe commented Feb 1, 2024

What is changed and how it works?

Issue Number: ref #16463

What's Changed:

Moved the analyze connect struct out of the big analyze.rs file and used the enum to represent the analyze version.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 1, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 1, 2024
0xPoe
0xPoe commented Feb 1, 2024
View reviewed changes
Copy link
Member Author

@0xPoe 0xPoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-check

0xPoe added 5 commits February 1, 2024 15:49
@0xPoe
statistics: move analyze context out
8e67261 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe
refactor: add comments
9c714c4 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe
refactor: remove dead code
5a2aca0 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe
refactor: use enum
af4e767 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe
fix: remove useless into
3e1239d 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe 0xPoe force-pushed the rustin-patch-analyze-context branch from c1a810c to 3e1239d Compare February 1, 2024 07:49
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 2, 2024
@overvenus
Copy link
Member

overvenus commented Feb 2, 2024

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

@overvenus: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3e1239d

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 2, 2024
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 2, 2024

@hi-rustin: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@0xPoe
Copy link
Member Author

0xPoe commented Feb 2, 2024

/test

@ti-chi-bot ti-chi-bot bot merged commit 8b7f647 into tikv:master Feb 2, 2024
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Feb 2, 2024
dbsid pushed a commit to dbsid/tikv that referenced this pull request Mar 24, 2024
@0xPoe @ti-chi-bot @dbsid
statistics: move analyze context out (tikv#16481)
4b4d523 
ref tikv#16463

Moved the analyze connect struct out of the big analyze.rs file and used the enum to represent the analyze version.

Signed-off-by: hi-rustin <rustin.liu@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: dbsid <chenhuansheng@pingcap.com>
@glorv glorv mentioned this pull request Dec 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

+1 more reviewer

@JmPotato JmPotato JmPotato approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

3 participants

@0xPoe @overvenus @JmPotato