resource_control: support manage resource group background metadata#14921
resource_control: support manage resource group background metadata#14921ti-chi-bot[bot] merged 8 commits intotikv:masterfrom
Conversation
Signed-off-by: glorv <glorvs@163.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
| default_group.name = DEFAULT_RESOURCE_GROUP_NAME.into(); | ||
| default_group.priority = MEDIUM_PRIORITY; | ||
| default_group.mode = GroupMode::RuMode; | ||
| default_group |
There was a problem hiding this comment.
the default_group will create in pd side, so tikv will automatically add the group. why do we need add this?
There was a problem hiding this comment.
The ResourceManage depend on the default group's exists to handle fallback logic. Since the watch pd logic is async, it's possible that the initialization don't finish before some task has come.
You can see in the previous version, we inited the default group at the ResouceController level, but in order to keep the ResourceLimiter when we update the cfg of resource group, I changed this init at ResourceGroupManager level, but the logic is still the same as before.
Signed-off-by: glorv <glorvs@163.com>
|
|
||
| impl ResourceGroupManager { | ||
| fn get_ru_setting(rg: &ResourceGroup, is_read: bool) -> u64 { | ||
| #[allow(clippy::new_without_default)] |
Signed-off-by: glorv <glorvs@163.com>
|
@nolouch @Connor1996 PTAL again, thanks~ |
|
/test |
1 similar comment
|
/test |
|
/merge |
|
@Connor1996: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 2b2cd9a |
|
@glorv: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…ikv#14921) ref tikv#14900 Signed-off-by: glorv <glorvs@163.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com>
What is changed and how it works?
Issue Number: ref #14900
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note