Skip to content

diagnostics: support cgroup limit memory#13237

Merged
ti-chi-bot merged 1 commit intotikv:masterfrom
Lloyd-Pottiger:support-cgroup-diagnostics-memory
Aug 8, 2022
Merged

diagnostics: support cgroup limit memory#13237
ti-chi-bot merged 1 commit intotikv:masterfrom
Lloyd-Pottiger:support-cgroup-diagnostics-memory

Conversation

@Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Aug 7, 2022 •
edited
Loading

Signed-off-by: Lloyd-Pottiger yan1579196623@gamil.com

What is changed and how it works?

Issue Number: Close #13217

What's Changed:

#13217 (comment)

support cgroup limit memory in diagnostics service

Check List

Tests

  • Integration test

Release note 

None

support cgroup limit memory in diagnostics service
7efb834 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gamil.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • sticnarf
  • tabokie

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Aug 7, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 7, 2022

Welcome @Lloyd-Pottiger!

It looks like this is your first PR to tikv/tikv 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/tikv. 😃

@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 7, 2022
sticnarf
sticnarf approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 8, 2022
@sticnarf
Copy link
Contributor

sticnarf commented Aug 8, 2022

/run-check-issue-triage-complete

@sticnarf sticnarf requested a review from tabokie August 8, 2022 03:00
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 8, 2022
@tabokie
Copy link
Member

tabokie commented Aug 8, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 8, 2022

@tabokie: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 8, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7efb834

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 8, 2022
@ti-chi-bot ti-chi-bot merged commit bec2627 into tikv:master Aug 8, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Aug 8, 2022
@Lloyd-Pottiger Lloyd-Pottiger deleted the support-cgroup-diagnostics-memory branch August 8, 2022 03:10
Lloyd-Pottiger added a commit to Lloyd-Pottiger/tidb-engine-ext that referenced this pull request Aug 8, 2022
@Lloyd-Pottiger
diagnostics: support cgroup limit memory (tikv#13237)
9d58df1 
close tikv#13217, ref tikv#13217

support cgroup limit memory in diagnostics service

Signed-off-by: Lloyd-Pottiger <yan1579196623@gamil.com>

Co-authored-by: Lloyd-Pottiger <yan1579196623@gamil.com>
CalvinNeo added a commit to pingcap/tidb-engine-ext that referenced this pull request Aug 8, 2022
@Lloyd-Pottiger @CalvinNeo
diagnostics: support cgroup limit memory (tikv#13237) (#138)
ec6e7ab 
close tikv#13217, ref tikv#13217

support cgroup limit memory in diagnostics service

Signed-off-by: Lloyd-Pottiger <yan1579196623@gamil.com>

Co-authored-by: Lloyd-Pottiger <yan1579196623@gamil.com>

Co-authored-by: Lloyd-Pottiger <yan1579196623@gamil.com>
Co-authored-by: Calvin Neo <CalvinNeo@users.noreply.github.com>
@Lloyd-Pottiger Lloyd-Pottiger mentioned this pull request Aug 9, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sticnarf sticnarf sticnarf approved these changes

@tabokie tabokie tabokie approved these changes

Assignees

No one assigned

Labels

contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

diagnostics: incorrect memory capacity with memory limit by cgroup

4 participants

@Lloyd-Pottiger @ti-chi-bot @sticnarf @tabokie