Skip to content

debug: Parameterize debug service#12960

Merged
ti-chi-bot merged 3 commits intotikv:masterfrom
CalvinNeo:merge-debug-service
Jul 8, 2022
Merged

debug: Parameterize debug service#12960
ti-chi-bot merged 3 commits intotikv:masterfrom
CalvinNeo:merge-debug-service

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jul 5, 2022

Signed-off-by: CalvinNeo calvinneo1995@gmail.com

What is changed and how it works?

Issue Number: ref #12849

What's Changed:

Parameterize debug service

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note 

None

@CalvinNeo
pa
225db0d 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. contribution This PR is from a community contributor. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2022
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 5, 2022

/cc @BusyJay @tonyxuqqi

@ti-chi-bot ti-chi-bot requested review from BusyJay and tonyxuqqi July 5, 2022 10:55
@CalvinNeo CalvinNeo mentioned this pull request Jul 5, 2022
Closed
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2022
BusyJay
BusyJay requested changes Jul 5, 2022
View reviewed changes
Copy link
Member

@BusyJay BusyJay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it compile first.

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 5, 2022
@CalvinNeo
f
40209a2 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 7, 2022

/run-all-tests

@CalvinNeo CalvinNeo requested a review from BusyJay July 7, 2022 14:41
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2022
@breezewish
Copy link
Member

breezewish commented Jul 8, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 8, 2022

@breezewish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 8, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 40209a2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 8, 2022

@CalvinNeo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit fc49bdf into tikv:master Jul 8, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Jul 8, 2022
ekexium pushed a commit to ekexium/tikv that referenced this pull request Jul 13, 2022
@CalvinNeo @ti-chi-bot @ekexium
debug: Parameterize debug service (tikv#12960)
a4f2a09 
ref tikv#12849

Parameterize debug service

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CalvinNeo added a commit to CalvinNeo/tidb-engine-ext that referenced this pull request Jul 22, 2022
@CalvinNeo @ti-chi-bot
debug: Parameterize debug service (tikv#12960)
d647bdc 
ref tikv#12849

Parameterize debug service

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BusyJay BusyJay BusyJay approved these changes

@breezewish breezewish breezewish approved these changes

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

Assignees

No one assigned

Labels

contribution This PR is from a community contributor. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

5 participants

@CalvinNeo @ti-chi-bot @breezewish @BusyJay @tonyxuqqi