Skip to content

raftstore: Implement observer on_compute_engine_size#12948

Merged
ti-chi-bot merged 13 commits intotikv:masterfrom
CalvinNeo:merge-tikv-storestats
Aug 3, 2022
Merged

raftstore: Implement observer on_compute_engine_size#12948
ti-chi-bot merged 13 commits intotikv:masterfrom
CalvinNeo:merge-tikv-storestats

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jun 30, 2022

Signed-off-by: CalvinNeo calvinneo1995@gmail.com

What is changed and how it works?

Issue Number: ref #12849

What's Changed:

Implement observer on_compute_engine_size

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note 

None

@CalvinNeo
initial
ed09305 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. contribution This PR is from a community contributor. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 30, 2022
@CalvinNeo CalvinNeo mentioned this pull request Jun 30, 2022
Closed
CalvinNeo added 3 commits June 30, 2022 22:43
@CalvinNeo
fix
9e7b720 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
fix
fb6c1d0 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
add tests
826cfc2 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 1, 2022

/cc @tonyxuqqi @BusyJay

@ti-chi-bot ti-chi-bot requested review from BusyJay and tonyxuqqi July 1, 2022 04:43
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 1, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2022
tonyxuqqi
tonyxuqqi approved these changes Jul 16, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 16, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2022
@CalvinNeo
f
db2c592 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2022
@CalvinNeo
f
7671a67 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
BusyJay
BusyJay reviewed Aug 2, 2022
View reviewed changes
@CalvinNeo
f
685236c 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo requested a review from BusyJay August 2, 2022 07:54
@CalvinNeo
f
a566728 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2022
@breezewish
Copy link
Member

breezewish commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2022

@breezewish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a566728

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2022

@CalvinNeo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 5c866c4 into tikv:master Aug 3, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Aug 3, 2022
CalvinNeo added a commit to CalvinNeo/tidb-engine-ext that referenced this pull request Aug 3, 2022
@CalvinNeo @tabokie @ti-chi-bot
raftstore: Implement observer on_compute_engine_size (tikv#12948)
2728f9e 
ref tikv#12849

Implement observer on_compute_engine_size

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>

Co-authored-by: Xinye Tao <xy.tao@outlook.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
CalvinNeo added a commit to pingcap/tidb-engine-ext that referenced this pull request Aug 9, 2022
@CalvinNeo @tabokie @ti-chi-bot
Support pd task observer to compute store stats for TiFlash (#136)
56761b7 
* raftstore: Implement observer on_compute_engine_size (tikv#12948)

ref tikv#12849

Implement observer on_compute_engine_size

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>

Co-authored-by: Xinye Tao <xy.tao@outlook.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>

* inc gc time

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>

Co-authored-by: Xinye Tao <xy.tao@outlook.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BusyJay BusyJay BusyJay approved these changes

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

Assignees

No one assigned

Labels

contribution This PR is from a community contributor. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

6 participants

@CalvinNeo @ti-chi-bot @breezewish @BusyJay @tonyxuqqi @tabokie