Skip to content

raftstore: Implement coprocessor observer pre_exec_admin(query)#12868

Merged
ti-chi-bot merged 19 commits intotikv:masterfrom
CalvinNeo:merge-tikv-pre-exec
Jul 13, 2022
Merged

raftstore: Implement coprocessor observer pre_exec_admin(query)#12868
ti-chi-bot merged 19 commits intotikv:masterfrom
CalvinNeo:merge-tikv-pre-exec

Conversation

@CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jun 21, 2022

Signed-off-by: CalvinNeo calvinneo1995@gmail.com

What is changed and how it works?

Issue Number: ref #12849

What's Changed:

Support new observers pre_exec_admin(query).

Note that when one of pre_exec_admin(query) observers returns true, raftstore will skip exec this cmd, but still reckon as applied.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note 

None

@CalvinNeo
add support
5887114 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BusyJay
  • tonyxuqqi

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2022
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jun 21, 2022

/cc @BusyJay @tonyxuqqi @breezewish

@CalvinNeo CalvinNeo mentioned this pull request Jun 21, 2022
Closed
CalvinNeo added 6 commits June 21, 2022 15:53
@CalvinNeo
elaborate
36d95ff 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
fix
c127687 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
fix
e7abeb0 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
fix
d8a7576 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
fix
fa9755f 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
f
96c4434 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jun 21, 2022

/run-all-tests

tonyxuqqi
tonyxuqqi reviewed Jun 28, 2022
View reviewed changes
tonyxuqqi
tonyxuqqi reviewed Jun 28, 2022
View reviewed changes
@tonyxuqqi
Copy link
Contributor

tonyxuqqi commented Jun 28, 2022

Generally LGTM

@CalvinNeo CalvinNeo requested a review from tonyxuqqi June 29, 2022 03:40
@CalvinNeo CalvinNeo mentioned this pull request Jul 5, 2022
Merged
@CalvinNeo
address comment
a330b5b 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2022
@CalvinNeo
fix
98c83b8 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 6, 2022
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 6, 2022
CalvinNeo added 3 commits July 6, 2022 13:11
@CalvinNeo
f
18b98fa 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
f
e0682ec 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
fix
e20c667 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
BusyJay
BusyJay reviewed Jul 12, 2022
View reviewed changes
@CalvinNeo
remove need_pre_exec
e037bb4 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 12, 2022
BusyJay
BusyJay reviewed Jul 12, 2022
View reviewed changes
@CalvinNeo
f
14c1c0c 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 12, 2022
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 13, 2022

/run-all-tests

breezewish
breezewish reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 13, 2022

@breezewish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@breezewish
Copy link
Member

breezewish commented Jul 13, 2022

/test

@breezewish
Copy link
Member

breezewish commented Jul 13, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 13, 2022

@breezewish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 13, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 491f1e7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2022
@ti-chi-bot ti-chi-bot merged commit 46d999d into tikv:master Jul 13, 2022
@ti-chi-bot ti-chi-bot added this to the Pool milestone Jul 13, 2022
CalvinNeo added a commit to CalvinNeo/tidb-engine-ext that referenced this pull request Jul 14, 2022
@CalvinNeo
raftstore: Implement coprocessor observer pre_exec_admin(query) (tikv…
e8e1851 
…#12868)

ref tikv#12849

Support new observers pre_exec_admin(query).

Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish left review comments

@BusyJay BusyJay BusyJay approved these changes

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

Assignees

No one assigned

Labels

contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

Pool

Development

Successfully merging this pull request may close these issues.

5 participants

@CalvinNeo @ti-chi-bot @tonyxuqqi @breezewish @BusyJay