server: check raft_client config change after flush#12781
server: check raft_client config change after flush#12781ti-chi-bot merged 9 commits intotikv:masterfrom
Conversation
Signed-off-by: glorv <glorvs@163.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
| } | ||
|
|
||
| #[bench] | ||
| fn bench_client_buffer_push(b: &mut test::Bencher) { |
There was a problem hiding this comment.
Better to move into tests/benches?
There was a problem hiding this comment.
There are bench cases both in the tests/benches and in the tests section of normal src files, is there any style guide about this?
…opt-buffer-push
|
/merge |
|
@zhangjinpeng1987: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 2e23288 |
|
@glorv: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…)" This reverts commit 050b6c0. Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
…ikv#12781)"" This reverts commit 0c20664. Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Signed-off-by: glorv glorvs@163.com
What is changed and how it works?
Issue Number: Close #12780
What's Changed:
Benchmark:
I use the
bench_client_buffer_pushto test this change. Because it's hard to mock the grpc connect inflush, I use theclearmethod to mock flush that only clean the buffer and check config change. This bench doesn't do config change simultaneously as the config change is rural.I run each bench for 10 times and choose the middle result, the middle result is almost equal to the avg result.
before:
after:
The bench result shows there is about 3% performance improvement. In theory, the cost of an atomic load is less than 10ns, so the theoretical extra cost of the check is about 5%. Thus, the bench result matches the expectation.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note