Conversation
This PR optimize debug build by disabling all debuginfo excepts tests itself. So that the generated artifacts will be smaller and also speed up compile time a little. Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
|
This is also a workaround for #4711. |
| [profile.dev] | ||
| opt-level = 0 | ||
| debug = true | ||
| debug = 0 |
There was a problem hiding this comment.
I think it's handy for debugging, let's make it to 1 as least? It's enabled on purpose before #5049
There was a problem hiding this comment.
I think it's handy for debugging
I set the tests to 1 for the exact purpose. So that we can see the exact panic point in tests. Setting global to 1 will make the target directory grow to 20GiB.
Connor1996
left a comment
There was a problem hiding this comment.
Should update the build issues part in CONTRIBUTING.md as well
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
|
/merge |
|
@BusyJay: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 40727da |
|
@YuJuncen PTAL at the fail case, it says |
I have noticed that too, I have located it and would fix it soon. (Even I'm not sure how it get broken...) |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-6.0 in PR #12726 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-6.1 in PR #12727 |
close #12707, ref #12708 This PR optimize debug build by disabling all debuginfo excepts tests itself. So that the generated artifacts will be smaller and also speed up compile time a little. Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Jay <BusyJay@users.noreply.github.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
What is changed and how it works?
Issue Number: Close #12707
What's Changed:
My local tests show that target directory changes from 45GiB to about 9.2GiB. And build time on Linux VM (8 vcores32GiB memory 2200MHz) is changing from 17m22s to 13m46s. The improvement probably comes from writing less data to disk.
Check List
Tests
Release note