Skip to content

Fix test_delegate_subscribe_unsubscribe flaking test#12309

Merged
hicqu merged 4 commits intotikv:masterfrom
0xPoe:rustin-patch-flaking
Mar 31, 2022
Merged

Fix test_delegate_subscribe_unsubscribe flaking test#12309
hicqu merged 4 commits intotikv:masterfrom
0xPoe:rustin-patch-flaking

Conversation

@0xPoe
Copy link
Member

@0xPoe 0xPoe commented Mar 30, 2022 •
edited
Loading

What is changed and how it works?

Issue Number: Close #12278

What's Changed:

Fix test_delegate_subscribe_unsubscribe flaking test. 
Use the corresponding id, otherwise there will be failures due to concurrent runs of the test. (We will assign downstream ids concurrently).

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

None

Release note 

None

0xPoe added 2 commits March 30, 2022 17:34
@0xPoe
Fix test_delegate_subscribe_unsubscribe flaking test
2b0319e 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@0xPoe
Remove println
5f85f5c 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hicqu
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 30, 2022
@0xPoe 0xPoe added component/CDC Component: Change Data Capture needs-cherry-pick-release-6.0 labels Mar 30, 2022
@0xPoe 0xPoe requested review from hicqu and overvenus and removed request for hicqu March 30, 2022 09:52
@0xPoe 0xPoe changed the title Rustin patch flaking Fix test_delegate_subscribe_unsubscribe flaking test Mar 30, 2022
@0xPoe 0xPoe requested a review from hicqu March 30, 2022 09:53
overvenus
overvenus approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2022
@JayiceZ
Copy link
Contributor

JayiceZ commented Mar 30, 2022 •
edited
Loading

Just curious, it seems like DOWNSTREAM_ID_ALLOC is an atomic var, why this problem happen?
Stupid me. Get it!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2022
@hicqu
Copy link
Contributor

hicqu commented Mar 31, 2022

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2022

@hicqu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2022

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 8900eda

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2022
@hicqu hicqu merged commit fd2bdd2 into tikv:master Mar 31, 2022
ti-srebot pushed a commit to ti-srebot/tikv that referenced this pull request Mar 31, 2022
@0xPoe @ti-srebot
cherry pick tikv#12309 to release-6.0
f026a8a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 31, 2022
Merged
@ti-srebot
Copy link
Contributor

ti-srebot commented Mar 31, 2022

cherry pick to release-6.0 in PR #12315

ti-chi-bot added a commit that referenced this pull request Apr 11, 2022
@ti-srebot @0xPoe
@hicqu @ti-chi-bot
Fix test_delegate_subscribe_unsubscribe flaking test (#12309) (#12315)
4dd5a13 
close #12278, ref #12309

Fix test_delegate_subscribe_unsubscribe flaking test. 
Use the corresponding id, otherwise there will be failures due to concurrent runs of the test. (We will assign downstream ids concurrently).

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: 二手掉包工程师 <rustin.liu@gmail.com>
Co-authored-by: qupeng <qupeng@pingcap.com>
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overvenus overvenus overvenus approved these changes

@hicqu hicqu hicqu approved these changes

Assignees

No one assigned

Labels

component/CDC Component: Change Data Capture needs-cherry-pick-release-6.0 release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test test_delegate_subscribe_unsubscribe sometimes fail

6 participants

@0xPoe @ti-chi-bot @JayiceZ @hicqu @ti-srebot @overvenus