resrc_mtr: add summary mod with a common framework#10973
Closed
mornyx wants to merge 37 commits intotikv:masterfrom
Closed
resrc_mtr: add summary mod with a common framework#10973mornyx wants to merge 37 commits intotikv:masterfrom
mornyx wants to merge 37 commits intotikv:masterfrom
Conversation
Signed-off-by: crazycs <chen.two.cs@gmail.com>
Signed-off-by: crazycs <chen.two.cs@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <chen.two.cs@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
fix cargo clippy adding todos for rw keys Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
Dev scan keys
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Member
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Member
|
Welcome @mornyx! |
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
…re/worker/pd.rs Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
zhongzc
reviewed
Sep 23, 2021
zhongzc
reviewed
Sep 23, 2021
zhongzc
reviewed
Sep 23, 2021
Comment on lines
+3
to
+20
| /// `Collector` is used to connect [Recorder] and [Reporter]. | ||
| /// | ||
| /// The `Recorder` is mainly responsible for collecting data, and it is | ||
| /// only responsible for passing the collected data to the `Collector`. | ||
| /// The `Recorder` does not know anything about "scheduling" or "uploading". | ||
| /// | ||
| /// Typically, constructing a `Collector` instance requires passing in a | ||
| /// [Scheduler], The `Collector` will send the data passed by the recorder | ||
| /// to the `Scheduler` for processing. | ||
| /// | ||
| /// `Reporter` implements [Runnable] and [RunnableWithTimer], aggregates the | ||
| /// data sent by the `Collector` internally, and reports it regularly through RPC. | ||
| /// | ||
| /// [Recorder]: crate::recorder::Recorder | ||
| /// [Reporter]: crate::reporter::Reporter | ||
| /// [Scheduler]: tikv_util::worker::Scheduler | ||
| /// [Runnable]: tikv_util::worker::Runnable | ||
| /// [RunnableWithTimer]: tikv_util::worker::RunnableWithTimer |
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
Member
|
@mornyx: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Added support for the collection and reporting of summary data recording the number of scanned keys. In addition, a general resource metering framework is abstracted, and cpu/summary related codes are used as sub-modules to work under the new framework.
What is changed and how it works?
What's Changed:
Recorder,ReporterandCollector.Related changes
pingcap/kvproto: pingcap/kvproto#814Check List
Tests
Side effects
Release note