resource_usage_agent: support summary data reporting#814
Merged
disksing merged 6 commits intopingcap:masterfrom Oct 9, 2021
Merged
resource_usage_agent: support summary data reporting#814disksing merged 6 commits intopingcap:masterfrom
disksing merged 6 commits intopingcap:masterfrom
Conversation
Signed-off-by: mornyx <mornyx.z@gmail.com>
|
|
disksing
approved these changes
Sep 23, 2021
breezewish
reviewed
Sep 23, 2021
Signed-off-by: mornyx <mornyx.z@gmail.com>
disksing
reviewed
Sep 24, 2021
Signed-off-by: mornyx <mornyx.z@gmail.com>
Signed-off-by: mornyx <mornyx.z@gmail.com>
breezewish
reviewed
Sep 28, 2021
| // | ||
| // Report the CPU time records. By default, the records with the same | ||
| // resource group tag will be batched by minute. | ||
| rpc ReportCPUTime(stream CPUTimeRecord) returns (EmptyResponse) {} |
Member
There was a problem hiding this comment.
We can change CPUTimeRecord to ResourceUsageRecord and not using CPUTimeRecord any more, since this change is compatible. For old clients, it will result in missing some new fields in the ResourceUsageRecord structure in the ReportCPUTime interface.
Contributor
Author
There was a problem hiding this comment.
I’m not sure before, it seems that the type name of the parameter does not affect compatibility?
Contributor
Author
There was a problem hiding this comment.
My idea is to keep the original proto text unchanged to avoid the illusion of breaking compatibility, and these will be deleted when the transition is completed.
breezewish
approved these changes
Oct 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mornyx mornyx.z@gmail.com