Skip to content

Scatter: make peer scatter logic same with the leader (#6965)#7028

Merged
ti-chi-bot[bot] merged 4 commits intotikv:release-7.1from
ti-chi-bot:cherry-pick-6965-to-release-7.1
Sep 28, 2023
Merged

Scatter: make peer scatter logic same with the leader (#6965)#7028
ti-chi-bot[bot] merged 4 commits intotikv:release-7.1from
ti-chi-bot:cherry-pick-6965-to-release-7.1

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Sep 1, 2023

This is an automated cherry-pick of #6965

What problem does this PR solve?

Issue Number: Close #6962

What is changed and how does it work?

In past, PD conside peer distribution in the different group influenece by using `TotalCountByStore` , but not include the leader distribution. The max used situation is partition table. 
After this pr, TIDB call scatter api will use same group not different. 

ref:
https://github.com/tikv/pd/pull/3422
https://github.com/pingcap/tidb/pull/46156

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

Release note

None.

@bufferflies @ti-chi-bot
This is an automated cherry-pick of tikv#6965
62057c0 
close tikv#6962

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 1, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Sep 1, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Sep 1, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 1, 2023
Merged
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx September 1, 2023 01:52
@bufferflies
resolve conflict
86b3c58 
Signed-off-by: bufferflies <1045931706@qq.com>
@codecov
Copy link

codecov bot commented Sep 4, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pkg/schedule/region_scatterer.go 78.90% <85.71%> (-0.20%) ⬇️

... and 28 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 8, 2023
@bufferflies
store id
75eecc8 
Signed-off-by: bufferflies <1045931706@qq.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 28, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 28, 2023
@CabinfeverB
Copy link
Member

CabinfeverB commented Sep 28, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 75eecc8

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 28, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 28, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CabinfeverB CabinfeverB mentioned this pull request Sep 28, 2023
Closed
@CabinfeverB CabinfeverB mentioned this pull request Sep 28, 2023
Closed
@ti-chi-bot ti-chi-bot bot merged commit 957fa0f into tikv:release-7.1 Sep 28, 2023
@HuSharp HuSharp deleted the cherry-pick-6965-to-release-7.1 branch October 1, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rleungx rleungx rleungx approved these changes

@HuSharp HuSharp HuSharp approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

Assignees

@CabinfeverB CabinfeverB

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @CabinfeverB @rleungx @HuSharp @bufferflies