Scatter peer should consider the group

## Bug Report

Right now, the scatter region consists of two parts: peer and leader. But the behavior is different. The scatter peer is according to the count of all groups, however, the scatter leader will use the count of a single group. It might cause the leader to be not balanced due to the wrong usage of TiDB. See https://github.com/pingcap/tidb/issues/46135.

https://github.com/tikv/pd/blob/70e9ffc3eda3718ba59d85bae1f2b5ef66e9bf63/pkg/schedule/scatter/region_scatterer.go#L453-L461

https://github.com/tikv/pd/blob/70e9ffc3eda3718ba59d85bae1f2b5ef66e9bf63/pkg/schedule/scatter/region_scatterer.go#L514-L524
 

	for _, store := range stores {
	count := context.selectedPeer.TotalCountByStore(store.GetID())
	if count > maxStoreTotalCount {
	maxStoreTotalCount = count
	}
	if count < minStoreTotalCount {
	minStoreTotalCount = count
	}
	}

	for _, storeID := range leaderCandidateStores {
	store := r.cluster.GetStore(storeID)
	if store == nil {
	continue
	}
	storeGroupLeaderCount := context.selectedLeader.Get(storeID, group)
	if minStoreGroupLeader > storeGroupLeaderCount {
	minStoreGroupLeader = storeGroupLeaderCount
	id = storeID
	}
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scatter peer should consider the group #6962

Bug Report

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Scatter peer should consider the group #6962

Description

Bug Report

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions