min-safe-ts: fix MinSafeTS might be set to MaxUint64 permanently#994
Merged
bufferflies merged 5 commits intotikv:masterfrom Oct 9, 2023
Merged
min-safe-ts: fix MinSafeTS might be set to MaxUint64 permanently#994bufferflies merged 5 commits intotikv:masterfrom
bufferflies merged 5 commits intotikv:masterfrom
Conversation
d927476 to
cb3ce6c
Compare
cb3ce6c to
aa81be7
Compare
disksing
approved these changes
Oct 7, 2023
Member
Author
|
@JmPotato PTAL, thx! |
JmPotato
reviewed
Oct 8, 2023
tikv/kv.go
Outdated
Comment on lines
+503
to
+505
| if val.(uint64) == uint64(math.MaxUint64) { | ||
| return 0 | ||
| } |
Member
There was a problem hiding this comment.
The key point is to prevent the MinSafeTS from not being updated permanently because of MaxUint64. We should handle it from the updater rather than just the getter.
Member
Author
There was a problem hiding this comment.
The core question is the getter
- we introduce
PD APIto not executego func which for KV request, resulting in not updatingsafeTSMap.updateMinSafeTSrelies onsafeTSMapwhich makes sense(because actually, we can callupdateMinSafeTStokvReuqestUpdater[to indicate func base]).
- And we need to update
minsafeTSto make sure when API fails we can fall back to the original way which is by kv request. - But the core problem is:
updateMinSafeTSwill returnmaxUnit64when the first kv request returns 0[maybe kv is not initialized] and then althoughPD APIreturns correctly, TS can not changemaxUnit64.- to resolve this question, we need to regard
maxUnit64as 0 which means there is an initial state.
- to resolve this question, we need to regard
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Member
Author
|
@nolouch PTAL as well, thx! |
JmPotato
reviewed
Oct 8, 2023
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
b3be48b to
3d9c8b0
Compare
JmPotato
approved these changes
Oct 9, 2023
iosmanthus
added a commit
that referenced
this pull request
Dec 20, 2023
Co-authored-by: cfzjywxk <cfzjywxk@gmail.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> Co-authored-by: disksing <i@disksing.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zzm <zhouzemin@pingcap.com> Co-authored-by: husharp <jinhao.hu@pingcap.com> Co-authored-by: you06 <you1474600@gmail.com> Co-authored-by: buffer <doufuxiaowangzi@gmail.com> Co-authored-by: 3pointer <qdlc2010@gmail.com> Co-authored-by: buffer <1045931706@qq.com> Co-authored-by: husharp <ihusharp@gmail.com> Co-authored-by: crazycs520 <crazycs520@gmail.com> Co-authored-by: Smilencer <smityz@qq.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: zyguan <zhongyangguan@gmail.com> Co-authored-by: Jack Yu <jackysp@gmail.com> Co-authored-by: Weizhen Wang <wangweizhen@pingcap.com> Co-authored-by: lucasliang <nkcs_lykx@hotmail.com> Co-authored-by: healthwaite <148101100+healthwaite@users.noreply.github.com> Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: ekexium <eke@fastmail.com> Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com> Co-authored-by: glorv <glorvs@163.com> Co-authored-by: Yongbo Jiang <cabinfeveroier@gmail.com> resolve locks interface for tidb gc_worker (#945) fix some issues of replica selector (#910) (#942) fix some issues of replica selector (#910) fix issue of configure kv timeout not work when disable batch client (#980) fix batch-client wait too long and add some metrics (#973) fix batch-client wait too long and add some metrics (#973)" (#984) fix data race at the aggressiveLockingDirty (#913) fix MinSafeTS might be set to MaxUint64 permanently (#994) fix: fix invalid nil pointer when trying to record Store.SlownessStat. (#1017) Fix batch client batchSendLoop panic (#1021) fix request source tag unset (#1025) Fix comment of `SuspendTime` (#1057)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #991
The core question is the getter
PD APIto not executego func which for KV request, resulting in not updatingsafeTSMap.updateMinSafeTSrelies onsafeTSMapwhich makes sense(because actually, we can callupdateMinSafeTStokvReuqestUpdater[to indicate func base]).minsafeTSto make sure when API fails we can fall back to the original way which is by kv request.updateMinSafeTSwill returnmaxUnit64when the first kv request returns 0 and then althoughPD APIreturns correctly[maybe kv is not initialized], TS can not changemaxUnit64.maxUnit64as 0 which means there is an initial state.