Merged
Conversation
Signed-off-by: hehechen <awd123456sss@gmail.com>
Contributor
Author
|
/cc @sticnarf @Connor1996 |
Contributor
Author
|
/run-all-tests |
JmPotato
reviewed
Dec 15, 2022
Member
JmPotato
left a comment
There was a problem hiding this comment.
Could we add a test for this change also? The rest LGTM.
lhy1024
reviewed
Dec 15, 2022
Contributor
lhy1024
left a comment
There was a problem hiding this comment.
Maybe we need to add some tests
Signed-off-by: hehechen <awd123456sss@gmail.com>
Signed-off-by: hehechen <awd123456sss@gmail.com>
lhy1024
approved these changes
Dec 16, 2022
Signed-off-by: hehechen <awd123456sss@gmail.com>
Contributor
Author
|
/cc @sticnarf |
Contributor
Author
|
/cc @disksing |
Collaborator
|
@hehechen There are race and lint errors. |
Collaborator
|
There is still a lint error remaining. You can ignore the integration test failure. It's just flaky. |
Contributor
Author
Done. Checked in local machine by |
12 tasks
hawkingrei
pushed a commit
to hawkingrei/client-go
that referenced
this pull request
Feb 24, 2023
Signed-off-by: hehechen <awd123456sss@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: hehechen awd123456sss@gmail.com
MinSafeTS support TiFlash to support TiFlash stale read.