remove testleak utilities#171
Merged
disksing merged 1 commit intotikv:masterfrom Jun 25, 2021
disksing:leaktest
Merged
Conversation
Signed-off-by: disksing <i@disksing.com>
tisonkun
reviewed
Jun 25, 2021
| } | ||
|
|
||
| func TestKVGetSet(t *testing.T) { | ||
| defer testleak.AfterTestT(t)() |
Contributor
There was a problem hiding this comment.
whether we just replace with defer goleak.VerifyNone(t) in this pass?
Collaborator
Author
There was a problem hiding this comment.
Adding in each Test is a bit tedious, I am going to add goleak in each package's TestMain. Please wait for my subsequent PR.
Contributor
There was a problem hiding this comment.
Well. Given leak tests don't in used actually. I'm ok with this.
tisonkun
approved these changes
Jun 25, 2021
tiancaiamao
pushed a commit
to tiancaiamao/client-go
that referenced
this pull request
Jul 8, 2021
Signed-off-by: disksing <i@disksing.com> Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>
daimashusheng
pushed a commit
to daimashusheng/client-go
that referenced
this pull request
Sep 2, 2021
Signed-off-by: disksing <i@disksing.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing i@disksing.com
Remove testleak as we are going to use goleak #169
pingcap/checkdependency is also finally resolved. Fix #97